Your message dated Mon, 16 Jun 2008 19:17:04 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#484334: fixed in devscripts 2.10.30
has caused the Debian Bug report #484334,
regarding devscripts: dch --create always launches editor
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
484334: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=484334
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.11ubuntu5.8.04.1
Severity: normal
Tags: patch

[Originally from Ubuntu LP: #220733; an Ubuntu developer asked me to file a 
Debian bug]

I expected 'dch --create "changelog entry"' to run in batch mode. Instead, it 
created a changelog in interactive mode and opened it in my editor. This makes 
it difficult to use dch --create from a script, which is my goal.

The dch man page says this:
"If the text of the change is given on the command line, debchange will run in 
batch mode and simply add the text, with line breaks as necessary, at the 
appropriate place in debian/changelog (or the changelog specified by options, 
as described below)."

Since I provided the text of the change, I expected dch to run in batch mode.

The attached patch (for devscripts in Ubuntu 8.04) does the following to fix 
the problem:
- Modify debchange.pl to not run the editor if the user passes --create, 
changelog text, --package, and -v.
- Modify debchange.pl to not write the "Initial release" line when changelog 
text is provided on the command line. This is avoids settings @closes_text, 
since the editor is launched whenever @closes_text is set. 


-- System Information:
Debian Release: lenny/sid
  APT prefers hardy-updates
  APT policy: (500, 'hardy-updates'), (500, 'hardy-security'), (500, 'hardy')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-17-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages devscripts depends on:
ii  debianutils             2.28.2-0ubuntu1  Miscellaneous utilities specific t
ii  dpkg-dev                1.14.16.6ubuntu3 package building tools for Debian
ii  libc6                   2.7-10ubuntu3    GNU C Library: Shared libraries
ii  perl                    5.8.8-12         Larry Wall's Practical Extraction 
ii  sed                     4.1.5-5          The GNU sed stream editor
ii  wget                    1.10.2-3ubuntu1  retrieves files from the web

Versions of packages devscripts recommends:
ii  debhelper                   6.0.4ubuntu1 helper programs for debian/rules
ii  fakeroot                    1.9ubuntu1   Gives a fake root environment

-- no debconf information
diff -Nru devscripts-2.10.11ubuntu5.8.04.1/debian/changelog 
devscripts-2.10.11ubuntu5.8.04.1msg1/debian/changelog
--- devscripts-2.10.11ubuntu5.8.04.1/debian/changelog   2008-05-07 
05:05:03.000000000 -0400
+++ devscripts-2.10.11ubuntu5.8.04.1msg1/debian/changelog       2008-06-03 
14:12:37.000000000 -0400
@@ -1,3 +1,12 @@
+devscripts (2.10.11ubuntu5.8.04.1msg1) hardy; urgency=low
+
+  * scripts/debchange.pl: Don't launch the editor when user passes a 
+    changelog entry to dch --create --package -v (LP: #220733)
+  * scripts/debchange.pl: Suppress "initial release" text when user 
+    passes a changelog entry to dch --create
+
+ -- Steve Magoun <[EMAIL PROTECTED]>  Tue, 03 Jun 2008 14:12:24 -0400
+
 devscripts (2.10.11ubuntu5.8.04.1) hardy-proposed; urgency=low
 
   * SRU to fix LP: #205388 - "Dch won't allow non-Ubuntu distros for -D
diff -Nru /tmp/QUoT1CUXdy/devscripts-2.10.11ubuntu5.8.04.1/scripts/debchange.pl 
/tmp/SiTeS8zIJR/devscripts-2.10.11ubuntu5.8.04.1msg1/scripts/debchange.pl
--- devscripts-2.10.11ubuntu5.8.04.1/scripts/debchange.pl       2008-05-07 
05:05:03.000000000 -0400
+++ devscripts-2.10.11ubuntu5.8.04.1msg1/scripts/debchange.pl   2008-06-03 
14:08:04.000000000 -0400
@@ -1151,7 +1151,7 @@
     $line=0;
 }
 elsif ($opt_create) {
-    if (! $initial_release and ! $opt_news) {
+    if (! $initial_release and ! $opt_news and ! $TEXT and ! $EMPTY_TEXT) {
        push @closes_text, "Initial release. (Closes: \#XXXXXX)\n";
     }
 
@@ -1190,7 +1190,7 @@
 }
 
 # Now Run the Editor; always run if doing "closes" to give a chance to check
-if ((!$TEXT and !$EMPTY_TEXT) or @closes_text or $opt_create) {
+if ((!$TEXT and !$EMPTY_TEXT) or @closes_text or ($opt_create && ! 
($opt_package && $opt_v))) {
     my $mtime = (stat("$changelog_path.dch"))[9];
     defined $mtime or fatal
        "Error getting modification time of temporary $changelog_path: $!";

--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.10.30

We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive:

devscripts_2.10.30.dsc
  to pool/main/d/devscripts/devscripts_2.10.30.dsc
devscripts_2.10.30.tar.gz
  to pool/main/d/devscripts/devscripts_2.10.30.tar.gz
devscripts_2.10.30_amd64.deb
  to pool/main/d/devscripts/devscripts_2.10.30_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam D. Barratt <[EMAIL PROTECTED]> (supplier of updated devscripts package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 16 Jun 2008 19:59:50 +0100
Source: devscripts
Binary: devscripts
Architecture: source amd64
Version: 2.10.30
Distribution: unstable
Urgency: low
Maintainer: Devscripts Devel Team <[email protected]>
Changed-By: Adam D. Barratt <[EMAIL PROTECTED]>
Description: 
 devscripts - scripts to make the life of a Debian Package maintainer easier
Closes: 484334 484582 485044 485094 485888 486013 486092 486159 486216 486344 
486395
Changes: 
 devscripts (2.10.30) unstable; urgency=low
 .
   * bts: MIME-encode the Subject: header of the generated mail in case it
     contains any non-ASCII characters (Closes: #486395)
   * checkbashisms:
     + Apply a couple of small fixes to the "quoted block detection" and the
       removal of quoted strings
     + Temporarily disable the $"" and $'' checks as they're very prone to
       false positives
     + Fix typoes in the heredoc and popd checks (Closes: #486159)
     + Fix a couple of small bugs in the "function name containing invalid
       characters" and "read with options other than -r" tests
   * debchange:
     + Don't automatically open an editor when creating a new changelog if
       a package name and version are supplied and either --empty was used
       or the text of a changelog entry was supplied on the command line.
       Based on a patch from Steve Magoun (Closes: #484334)
     + Don't automatically add an "initial release" stanza to a newly created
       changelog if the text of a changelog entry was supplied on the command
       line. Thanks Steve Magoun.
   * debcheckout:
     + Produce the correct URL for "project-based" darcs.d.o repositories in
       authenticated mode (Closes: #485044)
     + Correctly handle absolute pathnames as the checkout path for a single
       file (Closes: #485888)
   * debdiff: When using --show-moved, indicate whether the two lists of
     packages being compared are different (this should have always worked,
     but didn't due to a small logic bug)
   * licensecheck:
     + Apply patches from Ben Finney to use the copyright parser to determine
       whether a file contains a valid copyright statement (Closes: #486013)
       and to match more forms of copyright statement (Closes: #486216)
     + Handle another variant of the copyright symbol
   * tagpending: Add a comment to the generated e-mail indicating that the
     script was used (Closes: #486092)
   * who-uploads: Allow the date of each upload to be displayed. Based on a
     patch by Filippo Giunchedi (Closes: #486344)
   * wnpp-check: Fix a small typo in the manpage (Closes: #484582)
   * debian/control:
     + Bump Standards-Version to 3.8.0 (no changes)
     + Add bsd-mailx to the mailx | mailutils Recommends as mailx is now
       a transitional package for bsd-mailx
   * debian/{link,rules}: Don't install the fr/man1/dch.1 symlink if the
     corresponding debchange.1 wasn't installed (e.g. due to not being
     sufficiently translated) (Closes: #485094)
Checksums-Sha1: 
 be663f4b3b7e274259c6968ec90264056f07be3a 1393 devscripts_2.10.30.dsc
 7a2ed21979540e0a8752f9ad9cd2897c7f56fe8a 579873 devscripts_2.10.30.tar.gz
 026259ba50b872a104a3260004f4940faf1e0246 495016 devscripts_2.10.30_amd64.deb
Checksums-Sha256: 
 af44464360bba5b2f1dd332e4322f1fd37e788230a44f131cdde2226207f9611 1393 
devscripts_2.10.30.dsc
 eb4a0e555ee84ca2a90481193acc437da796f68d959ef1cde6b6140bd27ffe5c 579873 
devscripts_2.10.30.tar.gz
 be8b3680a63a07985ec59b986f40dedc88c7ef7c378368c4ecb81e842d2749f4 495016 
devscripts_2.10.30_amd64.deb
Files: 
 20545827dacbff26bff061e058279ffe 1393 devel optional devscripts_2.10.30.dsc
 088687abc4206bf46de1b1d73d5f70ce 579873 devel optional 
devscripts_2.10.30.tar.gz
 6ecd408084d63f712ce720419235681e 495016 devel optional 
devscripts_2.10.30_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkhWuSAACgkQokcE1TReOoWktACfWKnXrBtv/FIXSu7DYPmK9H8p
DvkAn1jFlw4DG9/k2rKCtJBQ0ppLa0G/
=ZwdI
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to