Author: adam-guest
Date: 2008-06-22 23:14:51 +0000 (Sun, 22 Jun 2008)
New Revision: 1520

Modified:
   trunk/Devscripts/Debbugs.pm
   trunk/debian/changelog
Log:
Debbugs.pm: Move initialisation of the SOAP object in to a common routine
and set the underlying transport object to honour proxies from the
environment (Closes: #487592)

Modified: trunk/Devscripts/Debbugs.pm
===================================================================
--- trunk/Devscripts/Debbugs.pm 2008-06-22 15:10:54 UTC (rev 1519)
+++ trunk/Devscripts/Debbugs.pm 2008-06-22 23:14:51 UTC (rev 1520)
@@ -92,6 +92,14 @@
 my $soapurl='Debbugs/SOAP/1';
 my $soapproxyurl='http://bugs.debian.org/cgi-bin/soap.cgi';
 
+sub init_soap {
+    my $soap = SOAP::Lite->uri($soapurl)->proxy($soapproxyurl);
+
+    $soap->transport->env_proxy();
+
+    return $soap;
+}
+
 my $soap_broken;
 sub have_soap {
      return ($soap_broken ? 0 : 1) if defined $soap_broken;
@@ -117,7 +125,7 @@
 
     my @args = @_;
 
-    my $soap = SOAP::Lite->uri($soapurl)->proxy($soapproxyurl);
+    my $soap = init_soap();
     my $usertags = $soap->get_usertag(@_)->result();
 
     return $usertags;
@@ -147,7 +155,7 @@
                       );
      my %users;
      my %search_parameters;
-     my $soap = SOAP::Lite->uri($soapurl)->proxy($soapproxyurl);
+     my $soap = init_soap();
      my $soapfault;
      $soap->on_fault(sub { $soapfault = $_; });
      for my $arg (@args) {
@@ -186,7 +194,7 @@
     die "Couldn't run status: $soap_broken\n" unless have_soap();
     my @args = @_;
 
-    my $soap = SOAP::Lite->uri($soapurl)->proxy($soapproxyurl);
+    my $soap = init_soap();
     my $soapfault;
     $soap->on_fault(sub { $soapfault = $_; });
 
@@ -234,7 +242,7 @@
     $search_parameters{arch} = [EMAIL PROTECTED] if @archs;
     $search_parameters{dist} = [EMAIL PROTECTED] if @dists;
 
-    my $soap = SOAP::Lite->uri($soapurl)->proxy($soapproxyurl);
+    my $soap = init_soap();
     my $soapfault;
     $soap->on_fault(sub { $soapfault = $_; });
 
@@ -267,7 +275,7 @@
 
     return if $count !~ /^\d+$/;
 
-    my $soap = SOAP::Lite->uri($soapurl)->proxy($soapproxyurl);
+    my $soap = init_soap();
     my $soapfault;
     $soap->on_fault(sub { $soapfault = $_; });
 
@@ -292,7 +300,7 @@
 
     return if $bug !~ /^\d+$/;
 
-    my $soap = SOAP::Lite->uri($soapurl)->proxy($soapproxyurl);
+    my $soap = init_soap();
     my $soapfault;
     $soap->on_fault(sub { $soapfault = $_; });
 
@@ -310,7 +318,7 @@
     die "Couldn't run binary_to_source: $soap_broken\n"
        unless have_soap();
 
-    my $soap = SOAP::Lite->uri($soapurl)->proxy($soapproxyurl);
+    my $soap = init_soap();
     my $soapfault;
     $soap->on_fault(sub { $soapfault = $_; });
 
@@ -334,7 +342,7 @@
     die "Couldn't run source_to_binary: $soap_broken\n"
        unless have_soap();
 
-    my $soap = SOAP::Lite->uri($soapurl)->proxy($soapproxyurl);
+    my $soap = init_soap();
     my $soapfault;
     $soap->on_fault(sub { $soapfault = $_; });
 

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog      2008-06-22 15:10:54 UTC (rev 1519)
+++ trunk/debian/changelog      2008-06-22 23:14:51 UTC (rev 1520)
@@ -9,6 +9,9 @@
     + Apply a small fix to part of the "quoted block detection"
     + Quote test expressions using qr to allow perl to optionally compile
       or otherwise optimise them. Thanks to Frank Lichtenheld for the idea.
+  * Debbugs.pm: Move initialisation of the SOAP object in to a common routine
+    and set the underlying transport object to honour proxies from the
+    environment (Closes: #487592)
   * debchange, nmudiff: Replace calls to date -R with strftime(). Thanks
     Stephen Gran (Closes: #486594)
   * licensecheck:



-- 
To unsubscribe, send mail to [EMAIL PROTECTED]

Reply via email to