Author: adam-guest
Date: 2008-07-06 21:09:49 +0000 (Sun, 06 Jul 2008)
New Revision: 1561
Modified:
trunk/debian/changelog
trunk/scripts/checkbashisms.pl
Log:
Fix FPs in the echo-with-unsafe-backslash tests
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2008-07-06 20:43:32 UTC (rev 1560)
+++ trunk/debian/changelog 2008-07-06 21:09:49 UTC (rev 1561)
@@ -4,8 +4,8 @@
+ Match the use of "shell echo -n" and "if foo then echo -n"
+ Fix a thinko in the quoted-block detection (thankfully the effects were
largely benign, unless one was attempting to check libtool...)
- + Fix a false positive in the checks for "dirs", "popd", "pushd", "shopt"
- and "ulimit"
+ + Fix false positives in the checks for "dirs", "popd", "pushd", "shopt"
+ and "ulimit" and the "echo with unsafe backslash" checks
* debchange: Also collapse UNRELEASED stanzas when -d is used
* debcheckout:
+ Improve git repository handling with --file
Modified: trunk/scripts/checkbashisms.pl
===================================================================
--- trunk/scripts/checkbashisms.pl 2008-07-06 20:43:32 UTC (rev 1560)
+++ trunk/scripts/checkbashisms.pl 2008-07-06 21:09:49 UTC (rev 1561)
@@ -487,12 +487,12 @@
qr'\$\{?PIPESTATUS\}?\b' => q<$PIPESTATUS>,
qr'\$\{?SHLVL\}?\b' => q<$SHLVL>,
qr'<<<' => q<\<\<\< here string>,
- $LEADIN .
qr'echo\s+(?:-[^e]+\s+)?([\"])[^\"]*(\\[\\abcEfnrtv0])+.*?[\"]' => q<unsafe
echo with backslash>,
+ $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\"[^\"]*(\\[\\abcEfnrtv0])+.*?[\"]'
=> q<unsafe echo with backslash>,
#'(?<![\$\\\])\$\"[^\"]+\"' => q<$"foo" should be eval_gettext "foo">,
);
%singlequote_bashisms = (
- $LEADIN .
qr'echo\s+(?:-[^e]+\s+)?([\'])[^\']*(\\[\\abcEfnrtv0])+.*?[\']' => q<unsafe
echo with backslash>,
+ $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\'[^\']*(\\[\\abcEfnrtv0])+.*?[\']'
=> q<unsafe echo with backslash>,
#'(?<![\$\\\])\$\'[^\']+\'' => q<$'...' should be
"$(printf '...')">,
);
--
To unsubscribe, send mail to [EMAIL PROTECTED]
