Your message dated Tue, 15 Jul 2008 18:47:04 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#490223: fixed in devscripts 2.10.34
has caused the Debian Bug report #490223,
regarding [checkbashisms] 'function' check is (again) not accurate
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
490223: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=490223
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.33
Severity: normal
Tags: checkbashisms, patch
Hi!
I was wondering why one of my scripts didn't work with /bin/sh -> dash,
while checkbashisms didn't complain:
=====
[EMAIL PROTECTED]:~$ volume-amixer.sh up
/usr/local/bin/volume-amixer.sh: 27: function: not found
/usr/local/bin/volume-amixer.sh: 32: Syntax error: "}" unexpected
[EMAIL PROTECTED]:~$ checkbashisms -n -f -x `which volume-amixer.sh`
possible bashism in /usr/local/bin/volume-amixer.sh line 43 (echo -n):
echo -n "$CONTROL_NAME volume "
possible bashism in /usr/local/bin/volume-amixer.sh line 49 (echo -n):
echo -n "unmute, "
possible bashism in /usr/local/bin/volume-amixer.sh line 62 (echo -n):
echo -n "up, "
possible bashism in /usr/local/bin/volume-amixer.sh line 70 (echo -n):
echo -n "down, "
possible bashism in /usr/local/bin/volume-amixer.sh line 74 (echo -e):
echo -e "Usage: $0 {mute|up|down}"
[EMAIL PROTECTED]:~$
=====
The problem is the same as bug #324599 [1], whose fix was reverted with
r1434. Since that commit was done to get in sync with lintian, lintian
is fault there too [3].
The patch is trivial:
--8<---------------cut here---------------start------------->8---
--- checkbashisms.~1~ 2008-07-09 17:30:11.000000000 +0200
+++ checkbashisms 2008-07-10 22:01:35.000000000 +0200
@@ -412,7 +412,7 @@
sub init_hashes {
my $LEADIN = qr'(?:(^|[`&;(|{])\s*|(if|do|while)\s+)';
%bashisms = (
- qr'(?:^|\s+)function \w+\(\s*\)' => q<'function' is useless>,
+ qr'(?:^|\s+)function \w+\s*' => q<'function' is useless>,
$LEADIN . qr'select\s+\w+' => q<'select' is not POSIX>,
$LEADIN . qr'source\s+(?:\.\/|\/|\$)[^\s]+' =>
q<should be '.', not 'source'>,
--8<---------------cut here---------------end--------------->8---
Now I can fix the other bashisms in my script ;-)
Thx, bye,
Gismo / Luca
Footnotes:
[1] http://bugs.debian.org/324599
[2]
http://svn.debian.org/viewsvn/devscripts/trunk/scripts/checkbashisms.pl?rev=1434&r1=1427&r2=1434
[3] I'd duplicate this bug as soon as the bug will be assigned a number
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.26-rc9-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages devscripts depends on:
ii dpkg-dev 1.14.20 Debian package development tools
ii libc6 2.7-12 GNU C Library: Shared libraries
ii perl 5.10.0-11 Larry Wall's Practical Extraction
Versions of packages devscripts recommends:
ii at 3.1.10.1 Delayed job execution and batch pr
ii bsd-mailx [mailx] 8.1.2-0.20071201cvs-3 A simple mail user agent
ii conkeror [www-brow 0.9~git080522-2 keyboard focused web browser with
ii curl 7.18.2-5 Get a file from an HTTP, HTTPS or
ii cvs 1:1.12.13-11 Concurrent Versions System
ii dctrl-tools 2.13.0 Command-line tools to process Debi
ii debian-keyring 2008.05.28 GnuPG (and obsolete PGP) keys of D
ii debian-maintainers 1.39 GPG keys of Debian maintainers
ii dput 0.9.2.32 Debian package upload tool
pn equivs <none> (no description available)
ii fakeroot 1.9.5 Gives a fake root environment
ii git-core 1:1.5.6.2-1 fast, scalable, distributed revisi
ii gnupg 1.4.9-2 GNU privacy guard - a free PGP rep
ii iceweasel [www-bro 3.0~rc2-2 lightweight web browser based on M
pn libauthen-sasl-per <none> (no description available)
pn libcrypt-ssleay-pe <none> (no description available)
pn libparse-debcontro <none> (no description available)
pn libsoap-lite-perl <none> (no description available)
pn libterm-size-perl <none> (no description available)
ii libtimedate-perl 1.1600-9 Time and date functions for Perl
ii liburi-perl 1.35.dfsg.1-1 Manipulates and accesses URI strin
pn libwww-perl <none> (no description available)
pn libyaml-syck-perl <none> (no description available)
ii lintian 1.24.1 Debian package checker
ii lsb-release 3.2-13 Linux Standard Base version report
ii man-db 2.5.2-1 on-line manual pager
ii openssh-client [ss 1:4.7p1-12 secure shell client, an rlogin/rsh
ii patch 2.5.9-5 Apply a diff file to an original
pn patchutils <none> (no description available)
ii strace 4.5.15-1.2 A system call tracer
ii subversion 1.4.6dfsg1-4 Advanced version control system
ii unzip 5.52-11 De-archiver for .zip files
ii w3m [www-browser] 0.5.2-2+b1 WWW browsable pager with excellent
ii wdiff 0.5-18 Compares two files word by word
ii wget 1.11.4-1 retrieves files from the web
-- no debconf information
pgp9xSEZpd32L.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.10.34
We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive:
devscripts_2.10.34.dsc
to pool/main/d/devscripts/devscripts_2.10.34.dsc
devscripts_2.10.34.tar.gz
to pool/main/d/devscripts/devscripts_2.10.34.tar.gz
devscripts_2.10.34_amd64.deb
to pool/main/d/devscripts/devscripts_2.10.34_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Adam D. Barratt <[EMAIL PROTECTED]> (supplier of updated devscripts package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 15 Jul 2008 19:24:29 +0100
Source: devscripts
Binary: devscripts
Architecture: source amd64
Version: 2.10.34
Distribution: unstable
Urgency: low
Maintainer: Devscripts Devel Team <[email protected]>
Changed-By: Adam D. Barratt <[EMAIL PROTECTED]>
Description:
devscripts - scripts to make the life of a Debian Package maintainer easier
Closes: 490223
Changes:
devscripts (2.10.34) unstable; urgency=low
.
* checkbashisms:
+ Match the use of "shell echo -n" and "if foo then echo -n"
+ Fix a thinko in the quoted-block detection (thankfully the effects were
largely benign, unless one was attempting to check libtool...)
+ Fix false positives in the checks for "dirs", "popd", "pushd", "shopt"
and "ulimit" and the "echo with unsafe backslash", brace expansion and
invalid function name checks
+ Fix a false-positive in the "source script with arguments check"
+ Fix a false negative in the "function" check (Closes: #490223)
+ Treat """" as "" when removing quotes
+ Catch shell script wrappers which use "foo $0 $@ &\nexec true"
+ Don't treat '. "a b"' as a sourced script being passed arguments
+ Strip leading @s from makefile lines
* debchange:
+ Also collapse UNRELEASED stanzas when -d is used
+ Fix a typo ("ether") in the manpage; thanks Raphael Geissert
* debcheckout:
+ Improve git repository handling with --file
+ Fix directory naming when using -f and no explicit destination directory
was specified
* uscan:
+ Parse sites which embed newlines inside hrefs (horrible, but works)
+ Always treat patterns referring to FTP sites as case-sensitive rather
than a confusing (and broken) mixture of case-sensitive and
case-insensitive matching
+ Correctly match directory names in HTMLised FTP proxy listings; the
equivalent change for filenames was applied in 2.10.11 (#448636)
Checksums-Sha1:
f76e51b40f9eb8ea1e985e0b0974b9894299f8fa 1393 devscripts_2.10.34.dsc
c12b3acf5512e663dcae72c2d4cdde022c3b8c64 586851 devscripts_2.10.34.tar.gz
ac9ba390c4cbbf26db097b5ecaa298ff186ceb50 498608 devscripts_2.10.34_amd64.deb
Checksums-Sha256:
c5f27e31f4a8a5c7738c1fe6e09a38fe06f7968aa257d1bfdd97666345c8134b 1393
devscripts_2.10.34.dsc
09520486c5c89f519dc5e51c3db621c35562ccb2753e3fe0884dd41ac18b90a2 586851
devscripts_2.10.34.tar.gz
c72d50d7d4ab7f7fecc4cfdb60d8a64821c748500210903564b5d16441c132a8 498608
devscripts_2.10.34_amd64.deb
Files:
91e3f3a36f1de03e42537320c4b119f5 1393 devel optional devscripts_2.10.34.dsc
3da6dce1fbfa018a2dff8674a65b4e4d 586851 devel optional
devscripts_2.10.34.tar.gz
563edc617c073d89f260223ad1000704 498608 devel optional
devscripts_2.10.34_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkh87BoACgkQokcE1TReOoXn+QCgljwJB2KKGsP7kqGLBNhAxhCb
zIUAnj7O9raD6JbUkreJQdgyxJkUP8M8
=dGJh
-----END PGP SIGNATURE-----
--- End Message ---
