Your message dated Wed, 05 Nov 2008 19:32:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#496065: fixed in devscripts 2.10.40
has caused the Debian Bug report #496065,
regarding [getbuildlog] Various improvements to the script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
496065: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=496065
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.35
Severity: wishlist

Hi,

I would like to see the appended patches be applied to getbuildlog.
Thanks.

Bye, Jörg.

-- System Information:
Debian Release: unstable/experimental
  APT prefers unstable
  APT policy: (900, 'unstable'), (700, 'experimental')
Architecture: powerpc (ppc)

Kernel: Linux 2.6.27-rc3
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to de_DE.UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages devscripts depends on:
ii  dpkg-dev                      1.14.20    Debian package development tools
ii  libc6                         2.7-13     GNU C Library: Shared libraries
ii  perl                          5.10.0-12  Larry Wall's Practical Extraction 

Versions of packages devscripts recommends:
pn  at                 <none>                (no description available)
ii  bsd-mailx [mailx]  8.1.2-0.20071201cvs-3 A simple mail user agent
ii  curl               7.18.2-7              Get a file from an HTTP, HTTPS or 
ii  cvs                1:1.12.13-11          Concurrent Versions System
ii  dctrl-tools        2.13.0                Command-line tools to process Debi
ii  debian-keyring     2008.07.22            GnuPG (and obsolete PGP) keys of D
ii  debian-maintainers 1.42                  GPG keys of Debian maintainers
ii  dillo [www-browser 0.8.6-3               Small and fast web browser
ii  dput               0.9.2.32              Debian package upload tool
ii  elinks [www-browse 0.11.4-2              advanced text-mode WWW browser
pn  equivs             <none>                (no description available)
ii  fakeroot           1.9.6                 Gives a fake root environment
ii  git-core           1:1.5.6.3-1           fast, scalable, distributed revisi
ii  gnupg              1.4.9-3               GNU privacy guard - a free PGP rep
ii  iceweasel [www-bro 3.0.1-1               lightweight web browser based on M
pn  libauthen-sasl-per <none>                (no description available)
ii  libcrypt-ssleay-pe 0.57-1+b1             Support for https protocol in LWP
pn  libparse-debcontro <none>                (no description available)
pn  libsoap-lite-perl  <none>                (no description available)
pn  libterm-size-perl  <none>                (no description available)
ii  libtimedate-perl   1.1600-9              Time and date functions for Perl
ii  liburi-perl        1.35.dfsg.1-1         Manipulates and accesses URI strin
ii  libwww-perl        5.813-1               WWW client/server library for Perl
pn  libyaml-syck-perl  <none>                (no description available)
ii  links2 [www-browse 2.1pre37-1.1          Web browser running in both graphi
ii  lintian            1.24.3                Debian package checker
ii  lsb-release        3.2-19                Linux Standard Base version report
ii  lynx-cur [www-brow 2.8.7dev9-1.2         Text-mode WWW Browser with NLS sup
ii  mailx              1:20071201-3          Transitional package for mailx ren
ii  man-db             2.5.2-2               on-line manual pager
ii  netsurf [www-brows 1.2-1                 Small portable web browser with CS
ii  openssh-client [ss 1:5.1p1-2             secure shell client, an rlogin/rsh
ii  patch              2.5.9-5               Apply a diff file to an original
ii  patchutils         0.2.31-4              Utilities to work with patches
ii  strace             4.5.17+cvs080723-2    A system call tracer
ii  subversion         1.5.1dfsg1-1          Advanced version control system
ii  unzip              5.52-12               De-archiver for .zip files
ii  w3m [www-browser]  0.5.2-2+b1            WWW browsable pager with excellent
ii  wdiff              0.5-18                Compares two files word by word
ii  wget               1.11.4-1              retrieves files from the web

Versions of packages devscripts suggests:
ii  build-essential               11.4       Informational list of build-essent
pn  cvs-buildpackage              <none>     (no description available)
pn  devscripts-el                 <none>     (no description available)
ii  gnuplot                       4.2.3-1    A command-line driven interactive 
pn  libfile-desktopentry-perl     <none>     (no description available)
pn  libnet-smtp-ssl-perl          <none>     (no description available)
ii  mutt                          1.5.18-4   text-based mailreader supporting M
pn  svn-buildpackage              <none>     (no description available)

-- no debconf information
From 665ef7f0211de7b83a38f86d746da51793496e77 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?J=C3=B6rg=20Sommer?= <[EMAIL PROTECTED]>
Date: Thu, 21 Aug 2008 11:22:26 +0200
Subject: [PATCH 1/5] Improve variable assignment

The variable expansion ${X:-Y} means expand $X if $X is set and not
empty, else expand Y. This is exactly what the former expression did.
---
 getbuildlog |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/getbuildlog b/getbuildlog
index 59768e9..daa0910 100755
--- a/getbuildlog
+++ b/getbuildlog
@@ -65,8 +65,8 @@ if [ ! -x "`which wget 2>/dev/null`" ]; then
 fi
 
 PACKAGE=$1
-VERSION=`(test -z "$2" && echo "[:~+.[:alnum:]-]+") || echo "$2"`
-ARCH=`(test -z "$3" && echo "[[:alnum:]-]+") || echo "$3"`
+VERSION=${2:-[:~+.[:alnum:]-]+}
+ARCH=${3:-[[:alnum:]-]+}
 ESCAPED_PACKAGE=`echo "$PACKAGE" | sed -e 's/\+/\\\+/g'`
 
 PATTERN="fetch\.(cgi|php)\?&pkg=$ESCAPED_PACKAGE&ver=$VERSION&arch=$ARCH&\
-- 
1.5.6.3

From 99a03bc528ed4ade5631e39d02b11bd7c74ea630 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?J=C3=B6rg=20Sommer?= <[EMAIL PROTECTED]>
Date: Thu, 21 Aug 2008 11:34:48 +0200
Subject: [PATCH 2/5] Replace string operations by shell expressions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

The task to extract these fields from the string can be done with shell
utils which saves pipes, forkes, …
---
 getbuildlog |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/getbuildlog b/getbuildlog
index daa0910..7b4a781 100755
--- a/getbuildlog
+++ b/getbuildlog
@@ -85,8 +85,10 @@ getbuildlog() {
     sed -i -e "s/%2B/\+/g" -e "s/%3A/:/g" $ALL_LOGS
 
     for match in `grep -E -o "$PATTERN" $ALL_LOGS`; do
-        ver=`echo $match | cut -d'&' -f3 | cut -d'=' -f2`
-        arch=`echo $match | cut -d'&' -f4 | cut -d'=' -f2`
+        ver=${match##*ver=}
+        ver=${ver%%&*}
+        arch=${match##*arch=}
+        arch=${arch%%&*}
 	match=`echo $match | sed -e 's/\+/%2B/g'`
         wget -O "${PACKAGE}_${ver}_${arch}.log" "$BASE/$match&file=log"
     done
-- 
1.5.6.3

From ede448c20122ba776ea7b68db7cff44efc0131de Mon Sep 17 00:00:00 2001
From: =?utf-8?q?J=C3=B6rg=20Sommer?= <[EMAIL PROTECTED]>
Date: Thu, 21 Aug 2008 14:43:01 +0200
Subject: [PATCH 3/5] Print a warning if downloading a log a second time

Some packages were built by more than one buildd. Tell the user about it.

Example:
http://buildd.debian-ports.org/fetch.php?&pkg=slrn&ver=0.9.8.1pl1-28&arch=armel
http://experimental.debian.net/fetch.php?&pkg=slrn&ver=0.9.8.1pl1-28&arch=armel
---
 getbuildlog |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/getbuildlog b/getbuildlog
index 7b4a781..fc70317 100755
--- a/getbuildlog
+++ b/getbuildlog
@@ -90,6 +90,9 @@ getbuildlog() {
         arch=${match##*arch=}
         arch=${arch%%&*}
 	match=`echo $match | sed -e 's/\+/%2B/g'`
+        if [ -e "${PACKAGE}_${ver}_${arch}.log" ]; then
+            echo "Found ${PACKAGE}_${ver}_${arch}.log a second time on $BASE"
+        fi
         wget -O "${PACKAGE}_${ver}_${arch}.log" "$BASE/$match&file=log"
     done
 
-- 
1.5.6.3

From 2138b8ce9337f85087ded3922cdcc68c7d03319f Mon Sep 17 00:00:00 2001
From: =?utf-8?q?J=C3=B6rg=20Sommer?= <[EMAIL PROTECTED]>
Date: Thu, 21 Aug 2008 14:46:27 +0200
Subject: [PATCH 4/5] Replace %7E by ~ in URLs

---
 getbuildlog |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/getbuildlog b/getbuildlog
index fc70317..d1e7508 100755
--- a/getbuildlog
+++ b/getbuildlog
@@ -82,7 +82,7 @@ getbuildlog() {
     # matches only one href. This is required because grep is greedy.
     sed -i -e "s/href=\"/\nhref=\"/g" $ALL_LOGS
     # Quick-and-dirty unescaping
-    sed -i -e "s/%2B/\+/g" -e "s/%3A/:/g" $ALL_LOGS
+    sed -i -e "s/%2B/\+/g" -e "s/%3A/:/g" -e "s/%7E/~/g" $ALL_LOGS
 
     for match in `grep -E -o "$PATTERN" $ALL_LOGS`; do
         ver=${match##*ver=}
-- 
1.5.6.3

From 95031a64e3d5b0894a91b299ba47c7b95ed3fcbd Mon Sep 17 00:00:00 2001
From: =?utf-8?q?J=C3=B6rg=20Sommer?= <[EMAIL PROTECTED]>
Date: Thu, 21 Aug 2008 14:50:43 +0200
Subject: [PATCH 5/5] Fetch only last version if version parameter is last

It's much more handy, especially in scripts, to fetch only the last
version without having to know the version number.
---
 getbuildlog   |   17 +++++++++++++++--
 getbuildlog.1 |    4 +++-
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/getbuildlog b/getbuildlog
index d1e7508..a005ad8 100755
--- a/getbuildlog
+++ b/getbuildlog
@@ -28,7 +28,8 @@ Usage: $PROGNAME <package> [<version-pattern>] [<architecture-pattern>]
   Downloads build logs of <package> from Debian auto-builders.
   If <version-pattern> or <architecture-pattern> are given, only build logs
   whose versions and architectures, respectively, matches the given patterns
-  are downloaded.
+  are downloaded. If <version-pattern> is last, only download the build logs
+  of the last version.
 Options:
   -h, --help        Show this help message.
   -V, --version     Show version and copyright information.
@@ -69,6 +70,13 @@ VERSION=${2:-[:~+.[:alnum:]-]+}
 ARCH=${3:-[[:alnum:]-]+}
 ESCAPED_PACKAGE=`echo "$PACKAGE" | sed -e 's/\+/\\\+/g'`
 
+if [ "$VERSION" = last ]; then
+    GET_ONLY_LAST_VERSION=true
+    VERSION='[:~+.[:alnum:]-]+'
+else
+    GET_ONLY_LAST_VERSION=false
+fi
+
 PATTERN="fetch\.(cgi|php)\?&pkg=$ESCAPED_PACKAGE&ver=$VERSION&arch=$ARCH&\
 stamp=[[:digit:]]+"
 
@@ -84,9 +92,14 @@ getbuildlog() {
     # Quick-and-dirty unescaping
     sed -i -e "s/%2B/\+/g" -e "s/%3A/:/g" -e "s/%7E/~/g" $ALL_LOGS
 
-    for match in `grep -E -o "$PATTERN" $ALL_LOGS`; do
+    last_ver=
+    for match in `grep -E -o "$PATTERN" $ALL_LOGS | tac`; do
         ver=${match##*ver=}
         ver=${ver%%&*}
+        if $GET_ONLY_LAST_VERSION && [ "${last_ver:-$ver}" != "$ver" ]; then
+            break
+        fi
+        last_ver=$ver
         arch=${match##*arch=}
         arch=${arch%%&*}
 	match=`echo $match | sed -e 's/\+/%2B/g'`
diff --git a/getbuildlog.1 b/getbuildlog.1
index 9861332..0376600 100644
--- a/getbuildlog.1
+++ b/getbuildlog.1
@@ -11,7 +11,9 @@ auto\-builders. It downloads build logs of all versions and for all
 architectures if \fIversion\-pattern\fR and \fIarchitecture\-pattern\fR are
 not specified or empty, otherwise only build logs whose versions match
 \fIversion-pattern\fR and build logs whose architectures match
-\fIarchitecture-pattern\fR will be downloaded. The version and architecture
+\fIarchitecture-pattern\fR will be downloaded. If \fIversion\-pattern\fP is
+last, only download the build logs of the last version. The version and
+architecture
 patterns are interpreted as extended regular expressions as described in
 \fBgrep\fR(1).
 .SH OPTIONS
-- 
1.5.6.3

Attachment: signature.asc
Description: Digital signature http://en.wikipedia.org/wiki/OpenPGP


--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.10.40

We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive:

devscripts_2.10.40.dsc
  to pool/main/d/devscripts/devscripts_2.10.40.dsc
devscripts_2.10.40.tar.gz
  to pool/main/d/devscripts/devscripts_2.10.40.tar.gz
devscripts_2.10.40_amd64.deb
  to pool/main/d/devscripts/devscripts_2.10.40_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam D. Barratt <[EMAIL PROTECTED]> (supplier of updated devscripts package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 05 Nov 2008 19:18:27 +0000
Source: devscripts
Binary: devscripts
Architecture: source amd64
Version: 2.10.40
Distribution: unstable
Urgency: low
Maintainer: Devscripts Devel Team <[email protected]>
Changed-By: Adam D. Barratt <[EMAIL PROTECTED]>
Description: 
 devscripts - scripts to make the life of a Debian Package maintainer easier
Closes: 483657 488717 495743 496065 497988 497995 499050 499264 499397 501252 
501568 502516 502517 503378 503950 504017
Changes: 
 devscripts (2.10.40) unstable; urgency=low
 .
   [ Adam D. Barratt ]
   * bts:
     + Update the manpage to mention local caching in the description
       section and correct a typo. (Closes: #499397)
     + Accept a command consisting purely of a comment. (Closes: #501252)
   * cowpoke:
     + Update to new upstream version
       - Multiple architecture and distribution support.
       - Options are now specified using --option rather than being listed
         after the .dsc file.
       - There is now a --create option to allow new build roots to be
         easily created.
       - There are two new configuration file options BUILDD_DIST (the
         default distribution for which packages will be built) and
         DEBOOTSTRAP, allowing one to specify which of {c,}debootstrap
         should be used.
       - The RESULT_DIR configuration variable has been replaced by
         PBUILDER_BASE which points to pbuilder's base folder under which
         architecture and distribution directories will be created.
       - cowpoke.conf now supports per-arch and per-distribution options.
   * debchange:
     + Don't attempt to automatically determine if the current changelog is
       an NMU if an alternative changelog location was specified using the
       CHANGELOG environment variable.
     + Update the Ubuntu distribution list. Add jaunty and remove the
       no-longer supported warty, hoary, edgy and fiesty. Also add
       "-backports" as a supported "extension".
     + Modify the message produced by --closes to make it clearer that it
       is intended to be edited to add details of the bug and fix as
       appropriate. (Closes: #495743)
   * debcommit:
     + Allow --release to be combined with --edit or --confirm. Based on
       a patch by Eric Gerlach. (Closes: #497988)
     + Allow a newly initialised (i.e. containing no HEAD) git tree to be
       committed to. Based on a patch by Eric Gerlach. (Closes: #497995)
   * debdiff: Correctly handle hyphenated distribution names when generating
     a diff against the previous version of the package. (Closes: #503950)
   * getbuildlog:
     + Apply some patches from Jörg Sommer (Closes: #496065)
       - Unescape %7Es in log URLs to allow explicitly searching for
         package versions containing tildes.
       - Simplify a couple of variable assignments and use shell string
         operations to extract the version and architecture from the logs.
     + Allow the logs for the build with the largest version number to be
       easily retrieved. Based on a patch by Jörg Sommer.
   * licensecheck: Match a couple more variants on the wording of a
     3-clause BSD license. (Closes: #503378)
   * nmudiff: Require an explicit confirmation as to whether the generated
     mail should be sent, rather than defauling to not sending it.
     (Closes: #483657)
   * tagpending: Don't output a spurious empty line near the end of the
     changelog comments under some circumstances.
   * uscan:
     + Document the USCAN_TIMEOUT configuration file variable.
       (Closes: #502517)
     + Add a USCAN_REPACK configuration file variable indicating that bzip
       tar or zip archives should always be repacked to gzip tar archives.
       (Closes: #502516)
 .
   [ Christoph Berg ]
   * debian/control: Remove the Dm-Upload-Allowed flag.
 .
   [ Stefano Zacchiroli ]
   * debcheckout:
     + try to guess repository type when given raw URLs
     + update user info about Vcs-* fields (correct developers' reference
       section, add an URL to it)
     + suggest using apt-get source as a fallback (Closes: #488717)
     + add support to define custom rules for authenticated mode, this way
       personal repos can benefit from '-a' (Closes: #501568)
     + add -d/--details option to print extended information about
       reopsitories, in machine parseable format. Implement dumping of
       TopGit-specific information for TopGit-enabled GIT repositories
     + initialize TopGit's automatically, for GIT repositories which are
       recognized as being managed with TopGit (Closes: #499264)
     + add --git-track option to require tracking of remote branches when
       checking out GIT repositories (Closes: #499050)
 .
   [ Patrick Schoenfeld ]
   * debsign: Unset GREP_OPTIONS to avoid problems when this variable is set
     in the users environment. (Closes: #504017)
Checksums-Sha1: 
 7a36779c5a779a96a7a1ce95290852c2484822d6 1363 devscripts_2.10.40.dsc
 dda43f3c41a437138ac49a2d3656569e35751fad 625530 devscripts_2.10.40.tar.gz
 acf75ada4f982092c7378ae88d7293458cbd0be8 539680 devscripts_2.10.40_amd64.deb
Checksums-Sha256: 
 cb73374f93a1ae0ea4f751fa64e8224d47e8c01b73457df6d920d725e225dc2c 1363 
devscripts_2.10.40.dsc
 73060bc625c184cb8e8efd3e5bee55f04b0ce6da499cefb49462e59333466d32 625530 
devscripts_2.10.40.tar.gz
 c1167629b3bafb39f4559d5ec14b32c9d4734110af068b0ad4f20debccf0cbfc 539680 
devscripts_2.10.40_amd64.deb
Files: 
 d801daffe9cf05b670c6db5ceb44c170 1363 devel optional devscripts_2.10.40.dsc
 9ec665f875c32c0bee14477f7f899a56 625530 devel optional 
devscripts_2.10.40.tar.gz
 b28c565e5fa83504ae0f7ee314261970 539680 devel optional 
devscripts_2.10.40_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkkR8vcACgkQokcE1TReOoXxuACfUIqhPiklWMO5vVg5Ao3ulrUY
u4QAn0DEKQUMzatG/FtNqkEbzxFv3+WP
=VA4t
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to