Author: adsb
Date: 2009-01-02 19:13:07 +0000 (Fri, 02 Jan 2009)
New Revision: 1775

Modified:
   trunk/debian/changelog
   trunk/scripts/checkbashisms.pl
Log:
* checkbashisms:
  + Flag the use of "source" with an unquoted argument containing no path
    information. (Closes: #510345)

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog      2009-01-02 18:28:59 UTC (rev 1774)
+++ trunk/debian/changelog      2009-01-02 19:13:07 UTC (rev 1775)
@@ -7,8 +7,11 @@
       don't always return "unknown".
     + Don't issue repeated "user foo" commands for the same user.
     + Remove excess whitespace from usertag commands.
-  * checkbashisms: Rework the comment detection code to avoid matching "$#"
-    and to avoid a number of similar issues. (Closes: #510343)
+  * checkbashisms:
+    + Rework the comment detection code to avoid matching "$#" and to avoid
+      a number of similar issues. (Closes: #510343)
+    + Flag the use of "source" with an unquoted argument containing no path
+      information. (Closes: #510345)
   * Debbugs.pm: Allow the address of the debbugs server to be specified
     rather than hard-coding bugs.debian.org.
   * debchange:

Modified: trunk/scripts/checkbashisms.pl
===================================================================
--- trunk/scripts/checkbashisms.pl      2009-01-02 18:28:59 UTC (rev 1774)
+++ trunk/scripts/checkbashisms.pl      2009-01-02 19:13:07 UTC (rev 1775)
@@ -538,7 +538,7 @@
 
     %singlequote_bashisms = (
        $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\'[^\']*(\\[\\abcEfnrtv0])+.*?[\']' 
=> q<unsafe echo with backslash>,
-       $LEADIN . qr'source\s+[\"\']?(?:\.\/|\/|\$)[^\s]+' =>
+       $LEADIN . qr'source\s+[\"\']?(?:\.\/|\/|\$|[\w.-])[^\s]+' =>
                                       q<should be '.', not 'source'>,
     );
 



-- 
To unsubscribe, send mail to [email protected].

Reply via email to