On Fri, 2009-04-10 at 22:18 +0200, Jan Hauke Rahm wrote:
> I'd like to see debtags functionality added to rc-alert (maybe also to
> wnpp-alert -- I'll have a look at it later). Reason is simple:
> contributors want to help but probably don't know every programming
> language. With debtags you can filter for packages implemented in a
> specific language.
>
> I've attached a patch to add this feature. It's very simple by now and
> only allows one debtag to look for. I consider extending that feature
> if you're willing to add it at all. :)
It's certainly not a feature I've ever thought about, but I've no
objections to adding it if people think it would be useful. :)
> rc-alert --debtags implemented-in::python
A few quick comments on the patch, if you don't mind:
Shoudn't it be --debtag if only one tag is allowed? </picky> There are a
few other places in the patch where the documentation can't decide
whether multiple tags are allowed or not.
> @@ -111,6 +118,7 @@
> "exclude-dists=s" => \$excludedists,
> "include-dist-op|o=s" => \$distincoperation,
> "exclude-dist-op=s" => \$distexcoperation,
> + "debtags=s" => \$debtags,
> );
Tab breakage.
> + while (defined(my $line = <DEBTAGS>)) {
> + if ($line =~ /^(.+?)(?::?\s*|:\s+(.+?)\s*)$/) {
Isn't that just
while (<DEBTAGS>) {
if (m/^(.+?)(?::?\s*|:\s+(.+?)\s*)$/) {
?
> @@ -210,6 +230,10 @@
>
> return unless $flagsapply and $distsapply;
>
> + if ($debtags) {
> + return unless ($dt_pkg{$args{pkg}} and $dt_pkg{$args{pkg}}
> =~ /$debtags/);
> + }
> +
> # yep, relevant
Broken indent again.
Apologies if any of the above seems picky. :-)
Regards,
Adam
--
To unsubscribe, send mail to [email protected].
