Author: adsb
Date: 2009-05-31 17:15:22 +0000 (Sun, 31 May 2009)
New Revision: 1899
Modified:
trunk/debian/changelog
trunk/scripts/checkbashisms.pl
Log:
Improve the check for the use of $[] inside quoted text. Thanks,
Raphael Geissert.
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2009-05-31 17:11:01 UTC (rev 1898)
+++ trunk/debian/changelog 2009-05-31 17:15:22 UTC (rev 1899)
@@ -17,6 +17,8 @@
(Closes: #531247)
+ Do not check the contents of a dpatch. The wrapper script always uses
/bin/sh and we can't detect the interpreter of a patch.
+ + Improve the check for the use of $[] inside quoted text. Thanks,
+ Raphael Geissert.
* licensecheck: Fix an error in a regular expression which led to an
uninitialized value warning and missing version for some GPL headers.
Thanks, Jakub Wilk. (Closes: #531059)
Modified: trunk/scripts/checkbashisms.pl
===================================================================
--- trunk/scripts/checkbashisms.pl 2009-05-31 17:11:01 UTC (rev 1898)
+++ trunk/scripts/checkbashisms.pl 2009-05-31 17:15:22 UTC (rev 1899)
@@ -480,7 +480,6 @@
$LEADIN . qr'exec\s+-[acl]' => q<exec -c/-l/-a name>,
$LEADIN . qr'let\s' => q<let ...>,
qr'(?<![\$\(])\(\(.*\)\)' => q<'((' should be '$(('>,
- qr'\$\[[^][]+\]' => q<'$[' should be '$(('>,
qr'(?:^|\s+)(\[|test)\s+-a' => q<test with unary -a (should
be -e)>,
qr'\&>' => q<should be \>word 2\>&1>,
qr'(<\&|>\&)\s*((-|\d+)[^\s;|)`&\\\\]|[^-\d\s]+)' =>
@@ -518,7 +517,7 @@
);
%string_bashisms = (
- qr'\$\[\w+\]' => q<arithmetic not allowed>,
+ qr'\$\[[^][]+\]' => q<'$[' should be '$(('>,
qr'\$\{\w+\:\d+(?::\d+)?\}' => q<${foo:3[:1]}>,
qr'\$\{!\w...@*]\}' => q<${!prefix[*|@]>,
qr'\$\{!\w+\}' => q<${!name}>,
--
To unsubscribe, send mail to [email protected].
