Author: adsb
Date: 2009-05-31 17:17:42 +0000 (Sun, 31 May 2009)
New Revision: 1901

Modified:
   trunk/debian/changelog
   trunk/scripts/checkbashisms.pl
Log:
Remove "\\" from the list of unsafe backslash escapes, as it appears to
work in all shells.

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog      2009-05-31 17:16:32 UTC (rev 1900)
+++ trunk/debian/changelog      2009-05-31 17:17:42 UTC (rev 1901)
@@ -20,6 +20,8 @@
     + Improve the check for the use of $[] inside quoted text.  Thanks,
       Raphael Geissert.
     + Apply the "common lead-in text" to the "readonly" check.
+    + Remove "\\" from the list of unsafe backslash escapes, as it appears to
+      work in all shells.
   * licensecheck: Fix an error in a regular expression which led to an
     uninitialized value warning and missing version for some GPL headers.
     Thanks, Jakub Wilk.  (Closes: #531059)

Modified: trunk/scripts/checkbashisms.pl
===================================================================
--- trunk/scripts/checkbashisms.pl      2009-05-31 17:16:32 UTC (rev 1900)
+++ trunk/scripts/checkbashisms.pl      2009-05-31 17:17:42 UTC (rev 1901)
@@ -535,11 +535,11 @@
        qr'\$\{?PIPESTATUS\}?\b'      => q<$PIPESTATUS>,
        qr'\$\{?SHLVL\}?\b'           => q<$SHLVL>,
        qr'<<<'                       => q<\<\<\< here string>,
-       $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\"[^\"]*(\\[\\abcEfnrtv0])+.*?[\"]' 
=> q<unsafe echo with backslash>,
+       $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\"[^\"]*(\\[abcEfnrtv0])+.*?[\"]' 
=> q<unsafe echo with backslash>,
     );
 
     %singlequote_bashisms = (
-       $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\'[^\']*(\\[\\abcEfnrtv0])+.*?[\']' 
=> q<unsafe echo with backslash>,
+       $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\'[^\']*(\\[abcEfnrtv0])+.*?[\']' 
=> q<unsafe echo with backslash>,
        $LEADIN . qr'source\s+[\"\']?(?:\.\/|\/|\$|[\w.-])[^\s]+' =>
                                       q<should be '.', not 'source'>,
     );



-- 
To unsubscribe, send mail to [email protected].

Reply via email to