Your message dated Wed, 29 Jul 2009 15:26:22 +0100 with message-id <38054b723c927941c84208e9c2fea4ac.squir...@localhost> and subject line Re: Bug#539155: dch: force_save_on_release logic reverted? has caused the Debian Bug report #539155, regarding dch: force_save_on_release logic reverted? to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 539155: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=539155 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: devscripts Version: 2.10.52 Severity: normal Hi, dch has: if ($mtime == $newmtime && ! $opt_create && (!$opt_r || ($opt_r && $opt_force_save_on_release))) { warn "$progname: $changelog_path unmodified; exiting.\n"; exit 0; } So it will abort if we do a release (opt_r) and opt_force_on_release is true. Isn't that logic reverted? Shouldn't we save the changelog if opt_r is true and opt_force_save_on_release is also true: if ($mtime == $newmtime && ! $opt_create && (!$opt_r || ($opt_r && ! $opt_force_save_on_release))) { warn "$progname: $changelog_path unmodified; exiting.\n"; exit 0; } Cheers, -- Guido -- Package-specific info: --- /etc/devscripts.conf --- DEBUILD_PRESERVE_ENVVARS="CCACHE_DIR,DEB_BUILD_OPTIONS" --- ~/.devscripts --- Not present -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'stable'), (50, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.31-rc3 (SMP w/2 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages devscripts depends on: ii dpkg-dev 1.15.3.1 Debian package development tools ii libc6 2.9-12 GNU C Library: Shared libraries ii perl 5.10.0-24 Larry Wall's Practical Extraction Versions of packages devscripts recommends: ii at 3.1.10.2 Delayed job execution and batch pr ii bsd-mailx [mailx] 8.1.2-0.20081101cvs-2 A simple mail user agent ii bzr 1.16.1-1 easy to use distributed version co ii curl 7.19.5-1 Get a file from an HTTP, HTTPS or ii cvs 1:1.12.13-12 Concurrent Versions System ii dctrl-tools 2.13.1 Command-line tools to process Debi ii debian-keyring 2009.05.28 GnuPG (and obsolete PGP) keys of D ii debian-maintainers 1.63 GPG keys of Debian maintainers ii dput 0.9.4 Debian package upload tool ii epiphany-gecko [ww 2.26.1-1 Intuitive GNOME web browser - Geck ii equivs 2.0.7-0.1 Circumvent Debian package dependen ii fakeroot 1.12.4 Gives a fake root environment ii git-core 1:1.6.3.3-1 fast, scalable, distributed revisi ii gnupg 1.4.9-4 GNU privacy guard - a free PGP rep ii iceweasel [www-bro 3.0.12-1 lightweight web browser based on M ii libauthen-sasl-per 2.12-1 Authen::SASL - SASL Authentication ii libcrypt-ssleay-pe 0.57-1+b1 Support for https protocol in LWP ii libparse-debcontro 2.005-2 Easy OO parsing of Debian control- ii libsoap-lite-perl 0.710.08-2 Client and server side SOAP implem ii libterm-size-perl 0.2-4+b1 Perl extension for retrieving term ii libtimedate-perl 1.1600-9 Time and date functions for Perl ii liburi-perl 1.37+dfsg-1 Manipulates and accesses URI strin ii libwww-perl 5.829-1 WWW client/server library for Perl ii libyaml-syck-perl 1.07-1 fast, lightweight YAML loader and ii lintian 2.2.13 Debian package checker ii lsb-release 3.2-22 Linux Standard Base version report ii lynx-cur [www-brow 2.8.7rel.1-1 Text-mode WWW Browser with NLS sup ii man-db 2.5.5-2 on-line manual pager ii mercurial 1.3-2 scalable distributed version contr ii openssh-client [ss 1:5.1p1-5+b1 secure shell client, an rlogin/rsh ii patch 2.5.9-5 Apply a diff file to an original ii patchutils 0.3.1-2 Utilities to work with patches ii strace 4.5.17+cvs080723-2 A system call tracer ii subversion 1.5.6dfsg-1 Advanced version control system ii unzip 6.0-1 De-archiver for .zip files ii w3m [www-browser] 0.5.2-2.1 WWW browsable pager with excellent ii wdiff 0.5-18 Compares two files word by word ii wget 1.11.4-2 retrieves files from the web Versions of packages devscripts suggests: ii build-essential 11.4 Informational list of build-essent pn cvs-buildpackage <none> (no description available) pn devscripts-el <none> (no description available) pn gnuplot <none> (no description available) pn libfile-desktopentry-perl <none> (no description available) pn libnet-smtp-ssl-perl <none> (no description available) ii mutt 1.5.20-2 text-based mailreader supporting M ii svn-buildpackage 0.6.26 helper programs to maintain Debian -- no debconf information
--- End Message ---
--- Begin Message ---On Wed, July 29, 2009 14:42, Guido Günther wrote: > So it will abort if we do a release (opt_r) and opt_force_on_release is > true. Isn't that logic reverted? Shouldn't we save the changelog if > opt_r is true and opt_force_save_on_release is also true: > > if ($mtime == $newmtime && ! $opt_create && > (!$opt_r || ($opt_r && ! $opt_force_save_on_release))) { > > warn "$progname: $changelog_path unmodified; exiting.\n"; > exit 0; > } No :) In this case, "force save on release" means that the user has to explicitly save the changelog, not that dch will force-save it for them. Regards, Adam
--- End Message ---
