On Wed, Sep 02, 2009 at 01:06:48PM +0200, Emilio Pozuelo Monfort wrote: > Patrick Schoenfeld wrote: > > On Mon, Aug 31, 2009 at 10:09:05AM +0200, Emilio Pozuelo Monfort wrote: > >> I don't think so. > >> The manpage says: > >> > >> If a .changes, .dsc or .commands file is specified, it is signed, > >> otherwise, debian/changelog is parsed to determine the name of the > >> .changes file > >> to look for in the parent directory. > > > > I guess the irritating part about this manpage sentence is the part "to > > look for in the parent directory", but in reality the difference > > to be drawn of this is that if a changes file is specified we do not > > need to construct one ourself. > > I'm not sure I understand, so let me clarify to make sure we agree: > > If I specify a .changes file in the command line, that one should be taken, > and > --debs-dir/DEBRELEASE_DEBS_DIR should be ignored. > > If I don't specify a .changes file, e.g. I just run "debsign", then > --debs-dir/DEBRELEASE_DEBS_DIR will be taken into account (and if not > specified > it will default to ..) to look for the .changes file, guessing the > package/version by looking into debian/changelog. > > So my problem is exactly: > > If I specify a .changes file (e.g. foobar_1.0-1_i386.changes, or even > /home/emilio/foobar_1.0-1_i386.changes), then that file should be signed > without > mangling the path. > > Do we agree?
Not entirely. If you specify a changes file and you don't have a DEBRELEASE_DEBS_DIR setting, this should be taken. If you specify a changes file (without a path), and you have DEBRELEASE_DEBS_DIR set we should search for it in DEBRELEASE_DEBS_DIR. If we can't find it there we should search for it in the parent directory. Optionally this could be the other way round. E.g. first searching in the parent and then in the DEBRELEASE_DEBS_DIR setting, but then I don't really see the sense in setting this option. Basically DEBRELEASE_DEBS_DIR is a base directory setting. It doesn't depend on generating a changes filename, so it should work even when you give debsign the name of the changes file. If you specify a changes file with a full path it should be taken, regardless of weither DEBRELEASE_DEBS_DIR is set or not. Regards, Patrick -- To unsubscribe, send mail to [email protected].
