tags 542962 - patch thanks Hi,
On Mon, Nov 30, 2009 at 01:37:28PM -0000, Adam D. Barratt wrote:
Iain Lane wrote, Monday, November 30, 2009 12:50 PMOn Sat, Aug 22, 2009 at 04:43:41PM +0200, Jakub Wilk wrote: I often copy output of bts to mails that are meant to be sent to both [email protected] and a human. As I keep forgetting to add a "thanks" line between machine- and human-readable parts, it would be nice if bts were adding such a line.I just thought of this too, and cooked up a patch to implement it. Please merge if it's appropriate.bts already contains code to add "thanks" to the end of a mail if it's called in "force-interactive" mode, which is intended for the case where you want to force editing of the body before sending; see addfooter().If "thanks" is added in other circumstances, that should be by modifying the condition in the existing code. I believe that last time we discussed doing so automagically under non-force-interactive conditions (while implementing #474205) the consensus was that it wasn't useful, but that was 18 months ago so people may well have changed their minds. :-)
(Outlook Express?! :)Hm. Is there a case when 'thanks' would cause harm? Seems to me that adding it all the time would be safe, and would mean that users wouldn't have to think about whether it was necessary. I didn't notice the force-interactive stuff, so obviously my patch needs reworking in light of that (if you agree that this is reasonable).
Iain
signature.asc
Description: Digital signature
