Author: jamessan
Date: 2009-12-12 05:07:19 +0000 (Sat, 12 Dec 2009)
New Revision: 2050
Modified:
trunk/debian/changelog
trunk/scripts/checkbashisms.pl
Log:
* checkbashisms: Detect use of {x..z} expansion. Thanks to Raphael Geissert.
(Closes: #560774)
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2009-12-10 07:59:02 UTC (rev 2049)
+++ trunk/debian/changelog 2009-12-12 05:07:19 UTC (rev 2050)
@@ -1,13 +1,14 @@
devscripts (2.10.60) UNRELEASED; urgency=low
[ James Vega ]
- * NOT RELEASED YET
+ * checkbashisms: Detect use of {x..z} expansion. Thanks to Raphael
+ Geissert. (Closes: #560774)
[ Patrick Schoenfeld ]
* licensecheck: Add support for some common variants of the WTFPL
[ Ryan Niebur ]
- * Fix deb-reversion with recent dpkg-dev, thanks to Salvatore
+ * deb-reversion: Fix use with recent dpkg-dev, thanks to Salvatore
Bonaccorso (Closes: #559702)
-- Patrick Schoenfeld <[email protected]> Tue, 08 Dec 2009 10:01:04 +0100
Modified: trunk/scripts/checkbashisms.pl
===================================================================
--- trunk/scripts/checkbashisms.pl 2009-12-10 07:59:02 UTC (rev 2049)
+++ trunk/scripts/checkbashisms.pl 2009-12-12 05:07:19 UTC (rev 2050)
@@ -466,12 +466,11 @@
%bashisms = (
qr'(?:^|\s+)function \w+(\s|\(|\Z)' => q<'function' is useless>,
$LEADIN . qr'select\s+\w+' => q<'select' is not POSIX>,
- qr'(test|-o|-a)\s*[^\s]+\s+==\s' =>
- q<should be 'b = a'>,
+ qr'(test|-o|-a)\s*[^\s]+\s+==\s' => q<should be 'b = a'>,
qr'\[\s+[^\]]+\s+==\s' => q<should be 'b = a'>,
qr'\s\|\&' => q<pipelining is not POSIX>,
- qr'[^\\\$]\{([^\s\\\}]*?,)+[^\\\}\s]*\}' =>
- q<brace expansion>,
+ qr'[^\\\$]\{([^\s\\\}]*?,)+[^\\\}\s]*\}' => q<brace expansion>,
+ qr'\{\d+\.\.\d+\}' => q<brace expansion, should be $(seq a b)>,
qr'(?:^|\s+)\w+\[\d+\]=' => q<bash arrays, H[0]>,
$LEADIN . qr'read\s+(?:-[a-qs-zA-Z\d-]+)' => q<read with option other
than -r>,
$LEADIN . qr'read\s*(?:-\w+\s*)*(?:\".*?\"|[\'].*?[\'])?\s*(?:;|$)'
--
To unsubscribe, send mail to [email protected].
