The following commit has been merged in the master branch:
commit f30170294fcd64ebf080deffe5f9113a625c4db9
Author: James Vega <[email protected]>
Date:   Sat Apr 3 18:54:22 2010 -0400

    checkbashisms: Detect more Bash builtins -- readarray, mapfile, enable. 
(Closes: #568473)

diff --git a/debian/changelog b/debian/changelog
index 98d5e27..399d5b0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -35,6 +35,8 @@ devscripts (2.10.62) UNRELEASED; urgency=low
   * debuild: Expose two new variables (epoch-less source version, and upstream
     version) to hooks.  Thanks to gregor herrmann for the patch.  (Closes:
     573092)
+  * checkbashisms: Detect more Bash builtins -- readarray, mapfile, enable.
+    (Closes: #568473)
 
   [ Patrick Schoenfeld ]
   * nmudiff: Fix "[nmudiff] please include --tagpending option" by applying the
diff --git a/scripts/checkbashisms.pl b/scripts/checkbashisms.pl
index 2d4b7a7..64cccdb 100755
--- a/scripts/checkbashisms.pl
+++ b/scripts/checkbashisms.pl
@@ -487,14 +487,22 @@ sub init_hashes {
        $LEADIN . qr'trap\s+["\']?.*["\']?\s+.*[1-9]' => q<trap with signal 
numbers>,
        qr'\[\[(?!:)' => q<alternative test command ([[ foo ]] should be [ foo 
])>,
        qr'/dev/(tcp|udp)'          => q</dev/(tcp|udp)>,
-       $LEADIN . qr'suspend\s' =>        q<suspend>,
+       $LEADIN . qr'builtin\s' =>        q<builtin>,
        $LEADIN . qr'caller\s' =>         q<caller>,
-       $LEADIN . qr'complete\s' =>       q<complete>,
        $LEADIN . qr'compgen\s' =>        q<compgen>,
+       $LEADIN . qr'complete\s' =>       q<complete>,
        $LEADIN . qr'declare\s' =>        q<declare>,
-       $LEADIN . qr'typeset\s' =>        q<typeset>,
+       $LEADIN . qr'dirs(\s|\Z)' =>      q<dirs>,
        $LEADIN . qr'disown\s' =>         q<disown>,
-       $LEADIN . qr'builtin\s' =>        q<builtin>,
+       $LEADIN . qr'enable\s' =>         q<enable>,
+       $LEADIN . qr'mapfile\s' =>        q<mapfile>,
+       $LEADIN . qr'readarray\s' =>      q<readarray>,
+       $LEADIN . qr'shopt(\s|\Z)' =>     q<shopt>,
+       $LEADIN . qr'suspend\s' =>        q<suspend>,
+       $LEADIN . qr'time\s' =>           q<time>,
+       $LEADIN . qr'type\s' =>           q<type>,
+       $LEADIN . qr'typeset\s' =>        q<typeset>,
+       $LEADIN . qr'ulimit(\s|\Z)' =>    q<ulimit>,
        $LEADIN . qr'set\s+-[BHT]+' =>    q<set -[BHT]>,
        $LEADIN . qr'alias\s+-p' =>       q<alias -p>,
        $LEADIN . qr'unalias\s+-a' =>     q<unalias -a>,
@@ -503,11 +511,6 @@ sub init_hashes {
                => q<function names should only contain [a-z0-9_]>,
        $LEADIN . qr'(push|pop)d(\s|\Z)' =>    q<(push|pop)d>,
        $LEADIN . qr'export\s+-[^p]' =>  q<export only takes -p as an option>,
-       $LEADIN . qr'ulimit(\s|\Z)' =>         q<ulimit>,
-       $LEADIN . qr'shopt(\s|\Z)' =>          q<shopt>,
-       $LEADIN . qr'type\s' =>          q<type>,
-       $LEADIN . qr'time\s' =>          q<time>,
-       $LEADIN . qr'dirs(\s|\Z)' =>          q<dirs>,
        qr'(?:^|\s+)[<>]\(.*?\)'            => q<\<() process substituion>,
        $LEADIN . qr'readonly\s+-[af]' => q<readonly -[af]>,
        $LEADIN . qr'(sh|\$\{?SHELL\}?) -[rD]' => q<sh -[rD]>,

-- 
Git repository for devscripts


-- 
To unsubscribe, send mail to [email protected].

Reply via email to