On Fri, Apr 9, 2010 at 10:33 AM, Christian Marillat <[email protected]> wrote:
> James Vega <[email protected]> writes:
>> On Fri, Apr 09, 2010 at 11:04:26AM +0200, Martin Zobel-Helas wrote:
>>> Debian Policy says about this:
>>>
>>> | upstream_version:
>>> |
>>> | This is the main part of the version number. It is usually the version
>>> | number of the original ("upstream") package from which the .deb file has
>>> | been made, if this is applicable. Usually this will be in the same
>>> | format as that specified by the upstream author(s); however, it may need
>>> | to be reformatted to fit into the package management system's format and
>>> | comparison scheme.
>>> |
>>> | The comparison behavior of the package management system with respect to
>>> | the upstream_version is described below. The upstream_version portion of
>>> | the version number is mandatory.
>>> |
>>> | The upstream_version may contain only alphanumerics[32] and the
>>> | characters . + - : ~ (full stop, plus, hyphen, colon, tilde) and should
>>> | start with a digit. If there is no debian_revision then hyphens are not
>>> | allowed; if there is no epoch then colons are not allowed.
>>>
>>> so yes, maybe we should not use Dpkg::Version for comparing it.
>>
>> Interesting conclusion since the quoted part of policy specifies both
>> that “it may need to be reformatted to fit into the package management
>> system's format” and that the version “may contain only
>> alphanumerics[32] and the characters . + - : ~”.  This seems like
>> precisely the reason we have uversionmangle support in uscan -- to
>> mangle upstream's strange versions into something useful for Debian.
>>
>> I'm not strictly opposed to going back to the old behavior (which we can
>> do using Dpkg::Version), but I think there should be a good reason to
>> accept invalid versions.
>
> Debian policy is for ... Debian We don't have control for upstream
> filename.
>
> The error is after scanning the *upstream* filename on remote site.

Which we sort *after* applying uversionmangle.  Like I said,
uversionmangle specifically exists to convert upstream's version into
something that works for Debian.

$ cat watch
version=3
opts="uversionmangle=s/_preview/~preview/" \
http://sf.net/avidemux/avidemux_(.*)\.tar\.gz
$ uscan --watchfile ./watch --upstream-version 2.5.2 --package
avidemux --report --verbose
-- In ./watch, processing watchfile line:
   opts="uversionmangle=s/_preview/~preview/"
http://sf.net/avidemux/avidemux_(.*)\.tar\.gz
-- Found the following matching hrefs:
     avidemux_2.4_preview2.tar.gz
     avidemux_2.5.2.tar.gz
     avidemux_2.5.1.tar.gz
     avidemux_2.5.0.tar.gz
     avidemux_2.4.4.tar.gz
     avidemux_2.4.3.tar.gz
     avidemux_2.4.2.tar.gz
     avidemux_2.4.1.tar.gz
     avidemux_2.4.tar.gz
     avidemux_2.4_preview3.tar.gz
Newest version on remote site is 2.5.2, local version is 2.5.2
 => Package is up to date

-- 
James
GPG Key: 1024D/61326D40 2003-09-02 James Vega <[email protected]>




--
To unsubscribe, send mail to [email protected].

Reply via email to