Your message dated Wed, 14 Apr 2010 04:17:08 +0000
with message-id <[email protected]>
and subject line Bug#577654: fixed in devscripts 2.10.64
has caused the Debian Bug report #577654,
regarding devscripts: uscan broken: Use of uninitialized value $package in
exists at /usr/bin/uscan line 579.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
577654: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=577654
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.63
Severity: important
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Since today's upgrade uscan fails:
$ uscan -verbose -report
- -- Scanning for watchfiles in .
- -- Found watchfile in ./debian
Use of uninitialized value $package in exists at /usr/bin/uscan line 579.
[..]
I suspected that this is related to the changes with versort and
debversort (cf. #577043 and commits around this subject).
A little digging around:
* @debdirs in uscan, beforeline line 559:
$VAR1 = [
'0.03-1',
'.',
'libmemoize-memcached-perl',
'0.03'
];
* @debdirs afterwards:
$VAR1 = [
'0.03-1',
'.'
];
That explains why $package is not initialized in line 579 :)
So the problem is in Devscripts::Versort::deb_versort().
The _versort() sub with the map/sort/map combination gave me a bit of
a headache, so I tried to analyze it step by step (see attached
uscan.pl).
After transfering back the final result, which just maps all 4
elements, to Devscripts/Versort.pm uscan works for me in my quick
tests. Patch attached.
Cheers,
gregor
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iQIcBAEBCAAGBQJLxJWxAAoJELs6aAGGSaoGNKgQAIqd9QMcL7RL0PbsBujmw3By
I46TriysRsOx0NhrxFOkHlpspxdUwtdPD7iaurMd7fLVsVzDFja9u7iKvG3LLqRj
K9FfF5RqG5HqvJyLvutW1+SLAwwrseQ0fLdhqz1OaC+rV6pDcuMawVMzIs8pLNrQ
ohPRB9/sa6/5x2A6KUz3VUjuAOu+iOSrg6EkoG+3/2tTOMxfP5NcH0sLL6ectEgP
rIsNkKy2swbVpF+btV4642SyvBeeFegXD7pB9SIm/k+ob3pLEZ3fhwWHFZO1SW18
e4NI/KdEqAgHF4O/jb4ZGNUj7nagrkkHz2+jcq6GpGvx7OBF214rtc4iJzyBKFJg
+g/VGjf/aw9LzMCN+iEm6YTB+/enE5VWHhMNf/iv767J/NQMpVqrfgwkzxzEt575
1cfcqaKFQAjlO5ygfVnpJAfu4CWPIiQ4uRlEfY9AEaVwJlE66Hep4kLl3LXK9Nv0
DFR8Xo3q83BRiHJ351G0RKwPJbrijDKMGsBizX7MrZ6QfnOdygeuEC562bTdkjTe
VrpxNOVk+PSEPwKa9h4AzvhHMlB65LMcqavsaCZ/YmfZAlZEFTP6iCp5cPaJ9nqk
0e0K5PDbd2Vypdi1HlpWjahrhryVvIObsbrxFYFw6De6nghC4y14Wisdedqv63lN
hjyMR2ztjDIOv8x/ckzv
=9Qil
-----END PGP SIGNATURE-----
#!/usr/bin/perl
use Dpkg::Version;
use Data::Dumper;
# status of @debdirs in uscan, 565
@namever_pairs = [ '0.03-1', '.', 'libmemoize-memcached-perl', '0.03' ];
print Dumper @namever_pairs;
my $check = 0;
# from Devscripts::Versort, sub _versort
my @sorted = map { [$_->[0], $_->[1]] }
sort { $a->[2] <=> $b->[2] }
map { [$_->[0], $_->[1], Dpkg::Version->new($_->[0], check => $check)] }
@namever_pairs;
print Dumper @sorted;
# let's split it up
my @checked = map { [$_->[0], $_->[1], Dpkg::Version->new($_->[0], check => $check)] }
@namever_pairs;
print Dumper @checked;
# hm, at that point the package is lost, let's save it
my @checked2 = map { [$_->[0], $_->[1], $_->[2], Dpkg::Version->new($_->[0], check => $check)] }
@namever_pairs;
print Dumper @checked2;
# and now the sort, this time with [3]
my @sorted2 = map { [$_->[0], $_->[1], $_->[2]] }
sort { $a->[3] <=> $b->[3] }
@checked2;
print Dumper @sorted2;
# better, stick it together
my @sortednew = map { [$_->[0], $_->[1], $_->[2]] }
sort { $a->[3] <=> $b->[3] }
map { [$_->[0], $_->[1], $_->[2], Dpkg::Version->new($_->[0], check => $check)] }
@namever_pairs;
print Dumper @sortednew;
# ok, uversion is missing, maybe we need it later?
my @sortednew2 = map { [$_->[0], $_->[1], $_->[2], $_->[3]] }
sort { $a->[4] <=> $b->[4] }
map { [$_->[0], $_->[1], $_->[2], $_->[3], Dpkg::Version->new($_->[0], check => $check)] }
@namever_pairs;
print Dumper @sortednew2;
# good, now it looks like at the beginning
--- Versort.pm.orig 2010-04-13 17:37:35.000000000 +0200
+++ Versort.pm 2010-04-13 17:48:03.000000000 +0200
@@ -40,9 +40,9 @@
{
my ($check, @namever_pairs) = @_;
- my @sorted = map { [$_->[0], $_->[1]] }
- sort { $a->[2] <=> $b->[2] }
- map { [$_->[0], $_->[1], Dpkg::Version->new($_->[0], check =>
$check)] }
+ my @sorted = map { [$_->[0], $_->[1], $_->[2], $_->[3]] }
+ sort { $a->[4] <=> $b->[4] }
+ map { [$_->[0], $_->[1], , $_->[2], $_->[3],
Dpkg::Version->new($_->[0], check => $check)] }
@namever_pairs;
return reverse @sorted;
--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.10.64
We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive:
devscripts_2.10.64.dsc
to main/d/devscripts/devscripts_2.10.64.dsc
devscripts_2.10.64.tar.gz
to main/d/devscripts/devscripts_2.10.64.tar.gz
devscripts_2.10.64_i386.deb
to main/d/devscripts/devscripts_2.10.64_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
James Vega <[email protected]> (supplier of updated devscripts package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Format: 1.8
Date: Tue, 13 Apr 2010 23:46:10 -0400
Source: devscripts
Binary: devscripts
Architecture: source i386
Version: 2.10.64
Distribution: unstable
Urgency: low
Maintainer: Devscripts Devel Team <[email protected]>
Changed-By: James Vega <[email protected]>
Description:
devscripts - scripts to make the life of a Debian Package maintainer easier
Closes: 577654
Changes:
devscripts (2.10.64) unstable; urgency=low
.
[ Stefano Zacchiroli ]
* devscripts.1: generic documentation for $DEBEMAIL and $DEBFULLNAME
.
[ James Vega ]
* Devscripts::Versort: Correct _versort so the lists it returns aren't
shorter than the ones passed in to _versort. (Closes: #577654)
* debcheckout: Switch from using the Switch module to Perl 5.10's switch
feature.
Checksums-Sha1:
f56b98a173172fed69d1f0425fe87a1246153875 1443 devscripts_2.10.64.dsc
6e05c2251bd71f6cb09ee8882f4fb5889d011b84 690044 devscripts_2.10.64.tar.gz
f42c533795796d7a8d45ec1a0f45204410d76b39 594616 devscripts_2.10.64_i386.deb
Checksums-Sha256:
4a85d540979e4d8ab3ea091433dca812737f619efea8fa19833cbc8ab7cfd474 1443
devscripts_2.10.64.dsc
25e39bea6d218c3ac594addea34265a62e8c4e9d3811ac5321ff272e7e27b48f 690044
devscripts_2.10.64.tar.gz
27e524f00f950b633256e1a1ba35100bf06e4ac98ad282aefa3378d33e24656e 594616
devscripts_2.10.64_i386.deb
Files:
fb4cbe8b1ed23e59d1f09a2494d2d043 1443 devel optional devscripts_2.10.64.dsc
9125834bc2fa158ff35c9a58863d24a3 690044 devel optional
devscripts_2.10.64.tar.gz
ee19bcebae128913019eb469c129f860 594616 devel optional
devscripts_2.10.64_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEAREDAAYFAkvFP38ACgkQDb3UpmEybUBVvQCaAinYZdsTkIJTVWrvpnMFMolF
Q4oAoItO0gHWH6sNZKrw9hqV32QefSeB
=GRsT
-----END PGP SIGNATURE-----
--- End Message ---
