On Tue, May 25, 2010 at 10:45:47AM -0500, Raphael Geissert wrote: > On 25 May 2010 10:27, James Vega <[email protected]> wrote: > > On Tue, May 25, 2010 at 11:14 AM, Raphael Geissert <[email protected]> > > wrote: > >> I couldn't find another commit fixing the bug you found, so I'm going > >> to to include it in my next batch of changes (which I'm testing > >> against the archive as I type.) > > > > I included it in the commit that added changelog entries for your > > changes -- be54022. > > Right, didn't see it. (Could use \s instead, though :)
Good point. I'll make that change. I noticed via one of your other
patches what looks to be a bad check for file redirection.
qr'(<\&|>\&)\s*((-|\d+)[^\s;|)}`&\\\\]|[^-\d\s]+)' =>
q<should be \>word 2\>&1>,
This will have false positives for things like the following:
$as_echo "$as_me:${as_lineno-$LINENO}: error: $1" >&$3
That is, we should allow for the results of an expansion to be used for
“word” (according to SUS's[0] use of the term).
> If you allow me, attached is another mbox with two more patches. The
> archive-wide check is not done yet and I've only verified some of the
> results, but there doesn't seem to be any (major at least)
> bug/regression introduced by those changes. Some false positives are
> now visible because some portions of code are now actually checked,
> but that's it.
These changes introduces a false positive wrt here strings.
possible bashism in src/auto/configure line 4650 (<<< here string):
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: >>> Perl > 5.6
with 5.5 threads cannot be used <<<" >&5
On the plus isde, they fixed another false positive by properly handling
single-quoted strings that span multiple lines.
> They are both required to make checkbashisms actually find bashisms in
> complex scripts such as "configure" scripts.
Thanks,
[0]:
http://www.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_07_05
--
James
GPG Key: 1024D/61326D40 2003-09-02 James Vega <[email protected]>
signature.asc
Description: Digital signature
