Your message dated Mon, 02 Aug 2010 06:02:07 +0000
with message-id <[email protected]>
and subject line Bug#590178: fixed in devscripts 2.10.66
has caused the Debian Bug report #590178,
regarding [uscan] Extraneous quoting for dpkg --compare-versions calls.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
590178: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=590178
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.65.1
Severity: normal
Tags: patch

Hi,

uscan calls system() with a list, so there's no need to use stuff like
"'$variable'", that generates an extra couple of quotes, which dpkg
doesn't like:
| k...@bowmore:~/x/app/x11-xserver-utils.git$ LC_ALL=C uscan --no-conf 
--download --no-symlink --destdir . --package iceauth --upstream-version 1.0.3 
--watchfile debian/watch.iceauth 
| dpkg: version ''1.0.3'' has bad syntax: invalid character in version number
| dpkg: version ''1.0.3'' has bad syntax: invalid character in version number
| iceauth: Newer version (1.0.3) available on remote site:
|   http://xorg.freedesktop.org/releases/individual/app/iceauth-1.0.3.tar.gz
|   (local version is 1.0.3)
| iceauth: Successfully downloaded updated package iceauth-1.0.3.tar.gz

Meaning we get to download all tarballs (see x11-xserver-utils's
get-tarballs target), even though all of them are uptodate.

Please find attached a tested patch.

Mraw,
KiBi.

-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
DEBUILD_PRESERVE_ENVVARS=PATH
NMUDIFF_DELAY=2
DEBCHANGE_RELEASE_HEURISTIC=changelog
DEBCHANGE_AUTO_NMU=no
RMADISON_URL_MAP_udd=http://qa.debian.org/cgi-bin/madison.cgi
DEBUILD_DPKG_BUILDPACKAGE_OPTS='-us -uc'

-- System Information:
Debian Release: sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages devscripts depends on:
ii  dpkg-dev                      1.15.8     Debian package development tools
ii  libc6                         2.11.2-2   Embedded GNU C Library: Shared lib
ii  perl                          5.10.1-13  Larry Wall's Practical Extraction 

Versions of packages devscripts recommends:
ii  at                3.1.12-1               Delayed job execution and batch pr
ii  bsd-mailx [mailx] 8.1.2-0.20100314cvs-1  simple mail user agent
ii  bzr               2.1.2-1                easy to use distributed version co
ii  chromium-browser  5.0.375.99~r51029-4+b1 Chromium browser
ii  conkeror [www-bro 0.9.2+git100420-2      keyboard focused web browser with 
ii  curl              7.21.0-1               Get a file from an HTTP, HTTPS or 
ii  cvs               1:1.12.13-12           Concurrent Versions System
ii  dctrl-tools       2.14                   Command-line tools to process Debi
ii  debian-keyring [d 2010.06.08             GnuPG (and obsolete PGP) keys of D
ii  dput              0.9.6.1                Debian package upload tool
ii  equivs            2.0.8                  Circumvent Debian package dependen
ii  fakeroot          1.14.4-1               Gives a fake root environment
ii  git [git-core]    1:1.7.1-1              fast, scalable, distributed revisi
ii  git-core          1:1.7.1-1              fast, scalable, distributed revisi
ii  gnupg             1.4.10-4               GNU privacy guard - a free PGP rep
ii  libauthen-sasl-pe 2.1500-1               Authen::SASL - SASL Authentication
ii  libcrypt-ssleay-p 0.57-2                 Support for https protocol in LWP
ii  libjson-perl      2.21-1                 Perl module to parse and convert t
ii  libparse-debcontr 2.005-2                Easy OO parsing of Debian control-
ii  libsoap-lite-perl 0.712-1                Perl implementation of a SOAP clie
ii  libterm-size-perl 0.2-4+b1               Perl extension for retrieving term
ii  libtimedate-perl  1.2000-1               collection of modules to manipulat
ii  liburi-perl       1.54-1                 module to manipulate and access UR
ii  libwww-perl       5.836-1                Perl HTTP/WWW client/server librar
ii  libyaml-syck-perl 1.09-1                 Perl module providing a fast, ligh
ii  lintian           2.4.2                  Debian package checker
ii  lsb-release       3.2-23.1               Linux Standard Base version report
ii  lzma              4.43-14                Compression method of 7z format in
ii  man-db            2.5.7-3                on-line manual pager
ii  midori [www-brows 0.2.4-3                fast, lightweight graphical web br
ii  openssh-client [s 1:5.5p1-4              secure shell (SSH) client, for sec
ii  patch             2.6-2                  Apply a diff file to an original
ii  patchutils        0.3.1-2                Utilities to work with patches
ii  sensible-utils    0.0.4                  Utilities for sensible alternative
ii  strace            4.5.20-2               A system call tracer
ii  subversion        1.6.12dfsg-1           Advanced version control system
ii  unzip             6.0-4                  De-archiver for .zip files
ii  w3m [www-browser] 0.5.2-7                WWW browsable pager with excellent
ii  wdiff             0.6.3-1                Compares two files word by word
ii  wget              1.12-2                 retrieves files from the web
ii  xz-utils          4.999.9beta+20100713-1 XZ-format compression utilities

Versions of packages devscripts suggests:
ii  build-essential               11.5       Informational list of build-essent
pn  cvs-buildpackage              <none>     (no description available)
pn  devscripts-el                 <none>     (no description available)
pn  gnuplot                       <none>     (no description available)
pn  libfile-desktopentry-perl     <none>     (no description available)
ii  libnet-smtp-ssl-perl          1.01-2     SSL support for Net::SMTP
ii  mutt                          1.5.20-9   text-based mailreader supporting M
pn  svn-buildpackage              <none>     (no description available)
ii  w3m                           0.5.2-7    WWW browsable pager with excellent

-- no debconf information
>From c4922bf8d8ce8668e89bdc25c3fb70ff9ad34343 Mon Sep 17 00:00:00 2001
From: Cyril Brulebois <[email protected]>
Date: Sat, 24 Jul 2010 17:00:44 +0200
Subject: [PATCH] uscan: Get rid of extra quoting in dpkg --compare-versions 
calls.

Signed-off-by: Cyril Brulebois <[email protected]>
---
 scripts/uscan.pl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/uscan.pl b/scripts/uscan.pl
index c59b921..ec0df77 100755
--- a/scripts/uscan.pl
+++ b/scripts/uscan.pl
@@ -1194,7 +1194,7 @@ EOF
 
     # Can't just use $lastversion eq $newversion, as then 0.01 and 0.1
     # compare different, whereas they are treated as equal by dpkg
-    if (system("dpkg", "--compare-versions", "'$mangled_lastversion'", "eq", 
"'$newversion'") == 0) {
+    if (system("dpkg", "--compare-versions", "$mangled_lastversion", "eq", 
"$newversion") == 0) {
        if ($verbose or ($download == 0 and $report and ! $dehs)) {
            print $pkg_report_header;
            $pkg_report_header = '';
@@ -1221,7 +1221,7 @@ EOF
     # We use dpkg's rules to determine whether our current version
     # is newer or older than the remote version.
     if (!defined $download_version) {
-       if (system("dpkg", "--compare-versions", "'$mangled_lastversion'", 
"gt", "'$newversion'") == 0) {
+       if (system("dpkg", "--compare-versions", "$mangled_lastversion", "gt", 
"$newversion") == 0) {
            if ($verbose) {
                print " => remote site does not even have current version\n";
            } elsif ($dehs) {
-- 
1.7.1


--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.10.66

We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive:

devscripts_2.10.66.dsc
  to main/d/devscripts/devscripts_2.10.66.dsc
devscripts_2.10.66.tar.gz
  to main/d/devscripts/devscripts_2.10.66.tar.gz
devscripts_2.10.66_i386.deb
  to main/d/devscripts/devscripts_2.10.66_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
James Vega <[email protected]> (supplier of updated devscripts package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Format: 1.8
Date: Mon, 02 Aug 2010 01:31:38 -0400
Source: devscripts
Binary: devscripts
Architecture: source i386
Version: 2.10.66
Distribution: unstable
Urgency: low
Maintainer: Devscripts Devel Team <[email protected]>
Changed-By: James Vega <[email protected]>
Description: 
 devscripts - scripts to make the life of a Debian Package maintainer easier
Closes: 486823 534988 539688 580821 589607 590178 590832 590842 590930 591305
Changes: 
 devscripts (2.10.66) unstable; urgency=low
 .
   [ James Vega ]
   * bts:
     + Fix ability to clear all tags on a bug.  (Closes: #539688)
     + Detect invalid characters in usertags.  (Closes: #590930)
     + Allow specifying multiple tag modifiers (+, -, =) in one usertag stanza.
   * rc-alert: Add missing hyphens and correct formatting in the man page.
     Based on a patch by Salvatore Bonaccorso.  (Closes: #589607)
   * checkbashisms: Allow kill & trap XSI-isms unless --posix is given, as per
     Policy 3.9.1.0.  (Closes: #486823)
   * debchange: Add --[no]multimaint-merge option, corresponding to the
     DEBCHANGE_MULTIMAINT_MERGE configuration variable.  (Closes: #590842)
   * licensecheck: Add .pas, .inc, .dtd., .xsl, and .mod files to the default
     check list.  (Closes: #534988, #591305)
   * build-rdeps: Escape regular expression metacharacters in package names.
     (Closes: #590832)
   * Build-Depends on po4a (>= 0.40) so po4a recognizes .TQ macro.
 .
   [ Cyril Brulebois ]
   * uscan: Get rid of extra quoting in dpkg --compare-versions calls.
     (Closes: #590178)
 .
   [ Carsten Hey ]
   * debsign: Add options --re-sign and --no-re-sign to let the user choose
     whether an already signed file should be resigned.  (Closes: #580821)
Checksums-Sha1: 
 0822322a63a5331b26447cdc5a87bdd6c7d900b5 1443 devscripts_2.10.66.dsc
 d31d3517601834d8b7fefed99ef9e75fe6aebb95 695014 devscripts_2.10.66.tar.gz
 37c8aad9373b51f9f48ee862b132d93a806db6cc 598652 devscripts_2.10.66_i386.deb
Checksums-Sha256: 
 0cd7f9fba21f25421744296c795c03a59e4dd7f7a88292531533634b3affe9d7 1443 
devscripts_2.10.66.dsc
 0df2c838d877d92aae4d4f685e7a101a46767a1af92259b8fc8d4a1d3175a640 695014 
devscripts_2.10.66.tar.gz
 06c9cfa841e489f40d9bef2ae2dd4ed083d6ba715caa5bbe71065a5cc4006228 598652 
devscripts_2.10.66_i386.deb
Files: 
 6414db1d34f4c49de29baea16775aebb 1443 devel optional devscripts_2.10.66.dsc
 74b6f985483e1c9441e3a0cb920fb747 695014 devel optional 
devscripts_2.10.66.tar.gz
 315bbca9a9cc2eaa89d8371aa04da2c3 598652 devel optional 
devscripts_2.10.66_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEAREDAAYFAkxWXPoACgkQDb3UpmEybUB15QCffendxVgu/WuuZuiXwzp4c6uo
vfsAnj3wdeb5m+c9e98Ifwk3aYyY1h0k
=sXhj
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to