The following commit has been merged in the master branch:
commit faaea27bfceeced91297348ab1946c22bcd0924a
Author: James Vega <[email protected]>
Date:   Wed Mar 2 00:11:05 2011 -0500

    debuild: Use 3-argument form of open to suppress warnings about unused 
symbols.
    
    Closes: #606054
    Signed-off-by: James Vega <[email protected]>

diff --git a/debian/changelog b/debian/changelog
index a637ed8..33cd57a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+devscripts (2.10.72) UNRELEASED; urgency=low
+
+  * debuild: Use 3-argument form of open to suppress warnings about unused
+    symbols.  (Closes: #606054)
+
+ -- James Vega <[email protected]>  Wed, 02 Mar 2011 00:07:34 -0500
+
 devscripts (2.10.71) unstable; urgency=low
 
   [ Christoph Berg ]
diff --git a/scripts/debuild.pl b/scripts/debuild.pl
index 4fc97f9..7939376 100755
--- a/scripts/debuild.pl
+++ b/scripts/debuild.pl
@@ -1,4 +1,4 @@
-#! /usr/bin/perl -w
+#!/usr/bin/perl
 
 # Perl version of Christoph Lameter's build program, renamed debuild.
 # Written by Julian Gilbey, December 1998.
@@ -48,6 +48,7 @@
 # Please file a bug report if this is the case!
 
 use strict;
+use warnings;
 use 5.008;
 use File::Basename;
 use filetest 'access';
@@ -614,8 +615,8 @@ unless ($preserve_env) {
 umask 022;
 
 # Start by duping STDOUT and STDERR
-open OLDOUT, ">&STDOUT" or fatal "can't dup stdout: $!\n";
-open OLDERR, ">&STDERR" or fatal "can't dup stderr: $!\n";
+open OLDOUT, ">&", \*STDOUT or fatal "can't dup stdout: $!\n";
+open OLDERR, ">&", \*STDERR or fatal "can't dup stderr: $!\n";
 
 # Look for the debian changelog
 my $chdir = 0;
@@ -1278,8 +1279,8 @@ EOT
     close STDOUT;
     close STDERR;
     close BUILD;
-    open STDOUT, ">&OLDOUT";
-    open STDERR, ">&OLDERR";
+    open STDOUT, ">&", \*OLDOUT;
+    open STDERR, ">&", \*OLDERR;
     exit 0;
 }
 else {
@@ -1365,8 +1366,8 @@ sub fatal($) {
        close STDOUT;
        close STDERR;
        close BUILD;
-       open STDOUT, ">&OLDOUT";
-       open STDERR, ">&OLDERR";
+       open STDOUT, ">&", \*OLDOUT;
+       open STDERR, ">&", \*OLDERR;
     }
     die $msg;
 }

-- 
Git repository for devscripts


-- 
To unsubscribe, send mail to [email protected].

Reply via email to