Your message dated Sat, 25 Feb 2012 21:00:24 -0500
with message-id <[email protected]>
and subject line Re: Bug#578999: devscripts: bts.pl - Use qx() in place of
backtics
has caused the Debian Bug report #578999,
regarding devscripts: bts.pl - Use qx() in place of backtics
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
578999: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578999
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.64
Severity: wishlist
Tags: patch
The following patch suggest using qx() shell call syntax in place of
backtics.
Motivation:
1) Improved redability. Cases like:
echo this `date '+%Y%m%d'`
=>
echo this $(date '+%Y%m%d')
2) No font problems. On a small 10 inch netbook the backtics are
difficult to distinguish from other charatcers.
3) Easier typing. In non-US keyboards the backtics are not in so
convenient location. Accessing the backtick requires acrobatic
skills with a combination of AltGr + KEY + SPACE
The patch is against Git bc4d573
-- Package-specific info:
--- /etc/devscripts.conf ---
--- ~/.devscripts ---
Not present
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages devscripts depends on:
ii dpkg-dev 1.15.7.1 Debian package development tools
ii libc6 2.10.2-6 Embedded GNU C Library: Shared lib
ii perl 5.10.1-12 Larry Wall's Practical Extraction
Versions of packages devscripts recommends:
ii at 3.1.12-1 Delayed job execution and batch pr
ii bsd-mailx [mailx] 8.1.2-0.20100314cvs-1 simple mail user agent
ii bzr 2.1.1-1 easy to use distributed version co
ii curl 7.20.0-3+b1 Get a file from an HTTP, HTTPS or
ii cvs 1:1.12.13-12 Concurrent Versions System
ii dctrl-tools 2.14 Command-line tools to process Debi
ii debian-keyring [d 2010.03.31 GnuPG (and obsolete PGP) keys of D
ii dillo [www-browse 2.0-1 Small and fast web browser
ii dput 0.9.5.1 Debian package upload tool
ii elinks [www-brows 0.12~pre5-2 advanced text-mode WWW browser
ii epiphany-browser 2.29.3-1 Intuitive GNOME web browser
ii equivs 2.0.8 Circumvent Debian package dependen
ii fakeroot 1.14.4-1 Gives a fake root environment
ii git-core 1:1.7.0-1 fast, scalable, distributed revisi
ii gnupg 1.4.10-2 GNU privacy guard - a free PGP rep
ii iceweasel [www-br 3.5.8-1 Web browser based on Firefox
ii konqueror [www-br 4:4.3.4-1 KDE 4's advanced file manager, web
ii libauthen-sasl-pe 2.14-1 Authen::SASL - SASL Authentication
ii libcrypt-ssleay-p 0.57-2 Support for https protocol in LWP
ii libjson-perl 2.21-1 Perl module to parse and convert t
ii libparse-debcontr 2.005-2 Easy OO parsing of Debian control-
ii libsoap-lite-perl 0.711-1 Perl implementation of a SOAP clie
ii libterm-size-perl 0.2-4+b1 Perl extension for retrieving term
ii libtimedate-perl 1.2000-1 collection of modules to manipulat
ii liburi-perl 1.54-1 module to manipulate and access UR
ii libwww-perl 5.834-1 Perl HTTP/WWW client/server librar
ii libyaml-syck-perl 1.07-1 fast, lightweight YAML loader and
ii links [www-browse 2.2-1+b1 Web browser running in text mode
ii lintian 2.3.4 Debian package checker
ii lsb-release 3.2-23 Linux Standard Base version report
ii lynx-cur [www-bro 2.8.8dev.2-1 Text-mode WWW Browser with NLS sup
ii lzma 4.43-14 Compression method of 7z format in
ii mailx 1:20081101-2 Transitional package for mailx ren
ii man-db 2.5.7-2 on-line manual pager
ii mercurial 1.5.1-2 scalable distributed version contr
ii midori [www-brows 0.1.8-1 fast, lightweight graphical web br
ii openssh-client [s 1:5.3p1-3 secure shell (SSH) client, for sec
ii opera [www-browse 10.10.4742.gcc4.qt3 The Opera Web Browser
ii patch 2.6-2 Apply a diff file to an original
ii patchutils 0.3.1-2 Utilities to work with patches
ii sensible-utils 0.0.4 Utilities for sensible alternative
ii strace 4.5.19-2 A system call tracer
ii subversion 1.6.9dfsg-1 Advanced version control system
ii unzip 6.0-4 De-archiver for .zip files
ii w3m [www-browser] 0.5.2-4 WWW browsable pager with excellent
ii wdiff 0.5-21 Compares two files word by word
ii wget 1.12-2 retrieves files from the web
ii xemacs21-mule [ww 21.4.22-3 highly customizable text editor --
ii xz-utils 4.999.9beta+20100307-1 XZ-format compression utilities
Versions of packages devscripts suggests:
ii build-essential 11.4 Informational list of build-essent
pn cvs-buildpackage <none> (no description available)
ii devscripts-el 33.1 Emacs wrappers for the commands in
pn gnuplot <none> (no description available)
ii libfile-desktopentry-perl 0.04-2 Perl module to handle freedesktop
ii libnet-smtp-ssl-perl 1.01-2 SSL support for Net::SMTP
ii mutt 1.5.20-7 text-based mailreader supporting M
ii svn-buildpackage 0.7.1 helper programs to maintain Debian
ii w3m 0.5.2-4 WWW browsable pager with excellent
-- no debconf information
>From 47c5486911e7e805a985409ed638e7a0434b76f9 Mon Sep 17 00:00:00 2001
From: Jari Aalto <[email protected]>
Date: Sat, 24 Apr 2010 10:45:21 +0300
Subject: [PATCH] scripts/bts.pl: Use qx() in place of backtics
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Signed-off-by: Jari Aalto <[email protected]>
---
scripts/bts.pl | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/bts.pl b/scripts/bts.pl
index a2d100d..05edb20 100755
--- a/scripts/bts.pl
+++ b/scripts/bts.pl
@@ -462,7 +462,7 @@ if (@ARGV and $ARGV[0] =~ /^--no-?conf$/) {
$shell_cmd .= '[ -f $file ] && . $file; done;' . "\n";
# Read back values
foreach my $var (keys %config_vars) { $shell_cmd .= "echo \$$var;\n" }
- my $shell_out = `/bin/bash -c '$shell_cmd'`;
+ my $shell_out = qx( /bin/bash -c '$shell_cmd' );
@config_vars{keys %config_vars} = split /\n/, $shell_out, -1;
# Check validity
@@ -2441,7 +2441,7 @@ sub send_mail {
my $fromaddress = $fromaddresses[0];
# Message-ID algorithm from git-send-email
my $msgid = sprintf("%s-%s", time(), int(rand(4200)))."-bts-$fromaddress";
- my $date = `date -R`;
+ my $date = `qx( date -R );
chomp $date;
my $message = fold_from_header("From: $from") . "\n";
@@ -2560,7 +2560,7 @@ sub mailbtsall {
my $subject=shift;
my $body=shift;
- my $charset = `locale charmap`;
+ my $charset = qx( locale charmap );
chomp $charset;
$charset =~ s/^ANSI_X3\.4-19(68|86)$/US-ASCII/;
$subject = MIME_encode_mimewords($subject, 'Charset' => $charset);
--
1.7.0
--- End Message ---
--- Begin Message ---
tag 578999 wontfix
thanks
On Sat, Apr 24, 2010 at 10:54:53AM +0300, Jari Aalto wrote:
> The following patch suggest using qx() shell call syntax in place of
> backtics.
>
> Motivation:
>
> 1) Improved redability. Cases like:
>
> echo this `date '+%Y%m%d'`
> =>
> echo this $(date '+%Y%m%d')
>
> 2) No font problems. On a small 10 inch netbook the backtics are
> difficult to distinguish from other charatcers.
>
> 3) Easier typing. In non-US keyboards the backtics are not in so
> convenient location. Accessing the backtick requires acrobatic
> skills with a combination of AltGr + KEY + SPACE
These aren't convincing reasons to make changes to the script,
especially when such a trivial patch contains a bug (one of my
concerns in #659084).
--
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <[email protected]>
signature.asc
Description: Digital signature
--- End Message ---
