On Thu, Nov 15, 2007 at 12:48:55PM -0800, [EMAIL PROTECTED] wrote:

> > > Would update the comment at catalog:101 to include exactly which
> > > portions of the catalog state are protected by the lock?
> > 
> > Is "We need to lock the search database" not enough?  Note that the current
> > comment doesn't actually say anything about catalogs.
> 
> It looks like I was under the mistaken impression that the
> lock might be protecting one or more of searchdb_update_handle,
> _search_available, deferred_searchdb_updates, or pkg_root.  If we're
> just using this to prevent concurrent updates to the database, then
> nevermind.

Yep.  I'm happy to restructure __init__() or rewrite the comment to make
that clearer, if you think it's a reasonable mistake to make.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to