On Wed, Nov 21, 2007 at 01:02:49PM +0000, Trevor Watson wrote: > http://cr.opensolaris.org/~trevw/pkg-226/webrev3/
Looks good. I'll ask that you import errno and have ioe.errno test against errno.ENOENT. A couple of style nits: please use eight-space indentation consistently, and the final if clause in send_static() should have its body on a separate line. > As a side note, the code in 'send_static' in face.py would be cleaner if we > used Python 2.5 as this provides the try/finally construct plus another finally is available in 2.4 (and earlier; I'm not sure when it was introduced), but you're right that "with" would make things simpler here, precisely as it was intended to. Unfortunately, we don't have 2.5 yet. And finally doesn't actually help here, since you have except clauses for all the try statements. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
