On Mon, Dec 03, 2007 at 05:44:24PM -0800, [EMAIL PROTECTED] wrote:
> http://cr.opensolaris.org/~johansen/webrev-cat-inc/index.html
All nits -- I'm much happier with this than before.
catalog.py:
- line 553: this could be simplified to
return self.attrs.get("Last-Modified", None)
updatelog.py:
- line 59: Could we have a comment explaining the 336?
- line 158: I think this can be written as self._recv_updates(), if you
find that clearer.
- line 275: here's another place you can get rid of "default = ".
- line 333: does this need to be continued like it is?
- line 401: I know you did this for Catalog as well, but is there a
reason that you did this little alias, rather than just defined the
function outside the class?
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
