> > http://cr.opensolaris.org/~johansen/pkg-bugfix/index.html
> 
> client.py:
> 
>   - line 135: What's err.filename end up looking like?  You're not spitting
>     out anything based on auth here, like you are in the URLError bit; is
>     this equivalent?

This looks like URL : Error code - Message

I.e.

  http://localhost:10000/filelist_0 : 404 - Not found

> depot.py:
> 
>   - line 422: Bad check!  You should check the exception's args[0] and if
>     that's EPERM, then try again.

Are you sure it's EPERM?  The bind(3SOCKET) syscall returns EACCES in this
case, at least according to the manpage.

>   - line 425: The error messages should probably go to stderr.  To
>     facilitate this, you might reverse the check, which would allow you to
>     save an indent level on the prints

Ok, changed.

>   - line 427: "inststead" -> "instead"

Thanks.

>   - line 428: "Use -p option" -> "Use the -p option"

I had removed the "the" to keep it on one line.  If I change the
indentation then, yes, it becomes more grammatically appealing.  :P

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to