All, http://cr.opensolaris.org/~jhf/ips-multi-2/index.html
I have incorporated everyone's comments and have updated the code review. The new URL is above. I also generated a "webrev of webrevs" showing the changes I made since the last code review. It unfortunately also includes other changes that went in since the last CR, but it is 90% signal so you may feel it's useful if there were any particular changes you were hoping for. That's at: http://cr.opensolaris.org/~jhf/ips-multi-1-2-diffs/index.html The major changes are: - Renamed plat to portable - Updated the initialization of the platform-specific modules in pkg.portable.interface. Now, one only has to do: from pkg.portable.interface import impl as portable ... portable.chown(file, owner) portable.is_admin() ... The 'impl' is initialized once, at module import time (see interface.py). - Introduced shell script/batch file wrappers for use in multi-platform/multi-install, where the correct python is not always found in /usr/bin (these are not built using the Makefile support, only when distutils is used). - Updated ksh-based test scripts to work multi-platform (excluding Windows). - Introduced pylint configuration file and custom checker module for checking for non-portable API usage (this is invoked using 'python setup.py lint'). Please review at your earliest convenience. I am going to update the various (internal for now, pending inbound legal review) distros we have made available on the UC site. Once that's done I'll send a pointer. -jhf- _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
