> > http://cr.opensolaris.org/~johansen/pkg-unknown/
>
> catalog.py:
>
> - line 544 (and similar): consider the idiom:
>
> if cv in "CV" and ...
The only problem with this approach is that if we get a malformed line
that actually starts with CV it will pass the check. If you don't like
the (cv != "C" and cv != "V") portion, I could incorporate your approach
like this:
if (len(cv) == 1 and cv in "CV") or pkg != "pkg":
Do you like this better than the existing code?
> updatelog.py:
>
> - line 63: "catlog" -> "catalog". Unless we're taking notes about
> felines, in which case I think we're missing some code.
Heh, thanks for catching this.
> - line 64: "separated by spaces", no? And "server-side"; "serverside"
> sounds like a city in California.
Thanks for catching this too.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
