On Fri 22 Feb 2008 at 12:34AM, Richard Lowe wrote:
> "Shawn Walker" <[EMAIL PROTECTED]> writes:
> 
> > On Thu, Feb 21, 2008 at 11:25 PM, Dan Price <[EMAIL PROTECTED]> wrote:
> >> On Thu 21 Feb 2008 at 11:15PM, Shawn Walker wrote:
> >>  > It seems I flubbed up a bit and typo'd a constant name in four spots
> >>  > in depot.py for bug 255:
> >>
> >>  Review looks fine.  If you send me this as an "hg export", it'll
> >>  be formatted such that I can commit it and have the commit show
> >>  up as you.
> >
> > Attached.
> >
> >>  > This never revealed itself during the review, hg nits, my own checks,
> >>  > or "make test" sadly.
> >>
> >>  This is one of the things I really dislike about python.
> >
> > Count me in then.
> 
> Does pylint catch those?  I thought it at least tried to, but I could
> be wrong.
> 
> (whatever happened to you guys trying to get a pylint config together
> that was tolerable?)

Yes, it does.  We've played with it, but someone (really) needs to
sit down and work out how to fold it into our sourcebase.  In
particular, anything it considers "E" (error) is probably a bug.

        -dp

-- 
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to