Thus far the IPS project has been following, loosely, some conventions
which have long been shared by Opensolaris developers:
(a) Codereview required for all changes to the source tree.
(b) Test cases are developed near the end of the development
activity (or sometimes, not at all).
With respect to test cases, I've been wondering if there's an
opportunity for streamlining (a), and improving (b).
I see, roughly, two types of test cases:
1. Test cases attempting to validate areas of functionality
2. Test cases which validate that particular regressions
or defects have been fixed.
3. Test cases which illustrate a problem not yet fixed.
It seems to me that those developers who have commit access to the repo
should be able to check in test cases for Category (3) problems at the
time the bug is found, without code review required. As needed, we
could increase the committer list to accomodate greater test activity.
Essentially, I'm hoping to alter the activity as follows; note that each
step can be done by a separate person if needed.
OLD NEW
------------------------------------------------------------
Find bug Find bug
File bug File bug
Analyze & Triage Commit test case
Develop & Commit fix Analyze & Triage
Commit test case [maybe] Develop & Commit fix
Test changes exempt from review would only be in support of bugs which
are in the database (i.e. no adding failing test cases without associate
bugs). That is to say, you can't check in as follows:
I'd also propose that the test case be named after the bugid at least
until the bug is fixed.
My idea was that we could make it faster and easier to write test
cases which illustrate existing bugs, and faster and easier to write
test cases at the moment when bugs are discovered.
Writing new test cases for existing not-yet-fixed bugs would also
provide a simple and great way to introduce new people to the project.
I would propose we copy the mozilla.org keyword "needtestcase" and
tag bugs which need test cases appropriately.
Comments, etc. appreciated. I'd like to get to consensus. Once
there, I'll then write this up and put it on the website (if someone
will give me write access to the project web).
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
