On Tue 11 Mar 2008 at 09:02PM, Shawn Walker wrote:
> On Tue, Mar 11, 2008 at 8:57 PM, Danek Duvall <[EMAIL PROTECTED]> wrote:
> > On Tue, Mar 11, 2008 at 08:42:06PM -0500, Shawn Walker wrote:
> >
> > > Weird. I wonder why the tests and everything still passed. However,
> > > that makes sense now that you explain it.
> >
> > "NAME" in "NAME" happens to be True, so "foo.bar" will work. And it turns
> > out that Python parses "0.9" not as number-dot-number, but just as number.
> > If you'd added a test with "attr=0.9.1", I think that would have blown up.
> > You probably want to add that test. :)
>
> Thanks, I'll do that!
>
> > > You'll have to forgive me as I'm a relative Python novice.
> >
> > It's a common mistake, so don't feel bad.
> >
> > I'd also put a space after the comma on line 71.
>
> Noted.
Thanks for adding test cases. Shawn, I made you a committer for
the gate. Please use the power wisely :)
(Bart gave me a verbal +1 on this; I am assuming this is uncontroversial.)
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
