On Thu 03 Apr 2008 at 12:34PM, Danek Duvall wrote:
> On Thu, Apr 03, 2008 at 03:15:46AM -0700, Dan Price wrote:
>
> > http://cr.opensolaris.org/~dp/ips-cli-rewhack
>
> client.py:
> - line 635, 637: why not just do the str() once on line 612?
By keeping the action an "action", the action comparitor gets used. So
if you print raw actions and sort by that column, you'll get the "right"
sort order. There's more we could do here-- I think if we write a
"columnizer" class we can flesh this idea out further.
> manifest.py:
>
> - line 224: why the assert?
Ahh, because I now set self.size = 0. If you were to call
set_content multiple times, it would accumulate the added actions,
but the size would keep get reset to 0.
I can rectify this either by renaming the routine "add_content"
and making associated fixes, or we can be more strict about it
being "set_content" and wipe out the actions and size previously
stored. Do you have a preference?
In part the assert was there so I could see if we ever call
set_content() more than once (and, we don't).
I took the rest of your suggestions.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
