In general, I'm fine with this change. However, I think it would make sense to do the following:
a) Comment the units of measurement for the timeout. Is this 30 seconds, or some other number? b) If 30 is the default, allow the user to override the default by adding a command-line option. I'm assuming we'd only need to use this in a situation where we guessed wrong about the timeout. In such a case, it would be better to have a command-line option than to require the user to change the code. Thanks, -j On Mon, Apr 07, 2008 at 01:17:46PM -0700, Danek Duvall wrote: > http://cr.opensolaris.org/~dduvall/pkg-timeout/ > > This is a *very* simplistic addition to allow pkg(1) to timeout network > operations. There's no way to set the timeout, and the only codepaths that > check for the timeout exception are the two that already did some checking > for downloaded data (search and catalog refresh), so anywhere else it's > hit, you'll get a big fat traceback. I suppose that could be better than > hanging. > > At some point in the near future, I'll clean up the exception paths, add > retry, add partial download, etc. > > Thanks, > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
