Stephen Hahn wrote: > * Bart Smaalders <[EMAIL PROTECTED]> [2008-04-05 02:18]: >> 787 optional dependencies are required >> 900 Directory deletion needs to rely less on the kindness of strangers >> 948 image.get_link_actions() the cause of millions of syscalls during a >> fresh install >> >> http://cr.opensolaris.org/~barts/optional-dependencies/ >> >> I'll add some definitions of preliminary incorporations this weekend; >> they're just the redistributable packages w/ type=incorporate for now. >> I'll also add more bug reports; there are several incidental >> fixes/additions herein but I need to stop typing.... > > *. (Nit.) Sentences start with capital letters and "->" is usually > represented by the work "to". (Also, docstrings shouldn't start > with a leading space.) >
ok > modules/actions/depend.py: > > 67. How do you see this function changing for exclude dependencies? > (The leading boolean in the return tuple seems incomplete.) > > 107. Need an XXX here, I think. Is your intent to enhance > Depend.verify() in a later fix? > I've added to the comment; the code there now verifies incorporations as simple optional dependencies. We can restore the full verify when we can backtrack during plan creation. > modules/actions/directory.py: > > 145. If this line is the reason we added the image plan reference to > the image, shouldn't we just make each package plan have a > reference back to the containing image plan? > that works too.... I have no strong preference > modules/client/image.py: > > 1017. (Nit.) "do" should be "to". ok > > 1026. Could you mark this print with an XXX comment? I think we'll > need a better way to return this information up the call stack. > done > modules/manifest.py: > > 251. Do we need this "print l"? gone... a missed debugging artifact. > > publish.py: > > 198. (Nit.) Double "of" in comment. > > client.py: > > 447. I guess we need Image.list_uninstall() Not this wad. yup... I'll post a updated webrev after I get Danek's comments; this will include a couple of test cases and incorporations for builds 75, 79, and 86. - Bart -- Bart Smaalders Solaris Kernel Performance [EMAIL PROTECTED] http://blogs.sun.com/barts "You will contribute more with mercurial than with thunderbird." _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
