On Thu, Apr 10, 2008 at 01:32:49AM -0700, Dan Price wrote:
> Wow, this is more complicated than what I would have done, but kudos
> on knowing everything about % in python.
If you have suggestions on how to make it simpler, lemme know. Juggling
i18n, differing numbers of expandos, and where we know what those expandos
will be replaced with is a bit tricky. I could pass a list or tuple with
the expando values instead, I suppose, and add retcode's value to the end
of it. Is that what you were thinking? I guess I was worried about
ordering -- maybe retcode wouldn't always be the last expando. Turns out
it is, but when the messages are i18ned, won't the ordering often get
thrown out of whack, anyway?
> I like it mostly, but prefer the use of ----- as a spacer, perhaps.
Okay.
> Might there also be a bug here? It seems like you'd need to drain the
> stdout of the process prior to doing a wait()? Or maybe not.
Dunno if that's a problem or not. Perhaps if what it prints out is big
enough. I've moved the call to read().
> Need to use _()?
Sure.
http://cr.opensolaris.org/~dduvall/pkg-bug821-3/
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
