You keep forgetting to publish the webrev url ... :)
Makefile
- line 271, 278: shouldn't JUST_THESE_PKGS now be using -j?
publish_ips
- line 1: /usr/bin/ksh, please
- line 30: this seems *awfully* complicated to do what appears to be a
very simple thing.
- but I'm a bit confused -- doesn't the normal import process slurp in
SUNWipkg, too? Or is this for the "back-published" versions?
solaris.py
- line 750: all "s in strings" are lowercase, anyway, so this is either
redundant or paranoid.
- line 837: "args[0]" ought to be sufficient.
- line 903: debugging?
ClusterTools
- Why have the version in the package name?
NetBeans
- what's with all the commented-out bits?
Studio
- line 3: I'm not too psyched about putting dates in as version numbers.
If they ever want to switch back to something like 8.x, then they're
just screwed. This would be a good thing to put in a package attribute
as an upstream / marketing version number, but then I'm not sure what
the real version number ought to be. 12.x?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
