This change looks fine to me. -j
On Thu, Apr 17, 2008 at 01:44:53PM -0700, Danek Duvall wrote: > On Thu, Apr 17, 2008 at 12:35:17PM -0700, Dan Price wrote: > > > On Thu 17 Apr 2008 at 07:11AM, Danek Duvall wrote: > > > On Thu, Apr 17, 2008 at 09:58:18AM +0100, Trevor Watson wrote: > > > > > > > Danek Duvall wrote: > > > > > > > >> http://cr.opensolaris.org/~dduvall/pkg-misc2/ > > > > > > > > user.py > > > > Isn't the last pw.unlockfile() in this code trying to reference 'pw' > > > > from a different scope - I don't see 'pw' declared outside of the > > > > try/except block? > > > > As long as you're in user.py could you take a look at 1271? > > I've updated the webrev to include a fix for this. None of the previously > changed files have been updated, so the new review should be easy. > > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
