Don't check in pkgrecv.1 -- just the .txt file is needed. And wrap that
long long line.
pkgsend.py:
- I'd use -d instead of -b -- I think we'll want -b for prepending a path
onto the path attribute. pkgmk uses -r for what you're using -b for,
if you want to do that instead of -d.
- line 219: I'd refactor this a bit. In particular, everything currently
in the else clause could be outside, with just fullpath being set
appropriately in the if and the else side.
testutils.py:
- line 342, 346: spaces around =.
t_recv.py:
- line 85: this is probably a copy from somewhere else, but this does
mean that two people can't run tests on the machine at the same time.
- line 89: need parens.
pull.py:
- did you think about putting the files in the same directory structure
as they are on the server?
- line 77: why not just do the normal action parsing stuff?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
