The following webrev includes proposed fixes for the following bugs:
1854 rework depot to use higher-level framework
1154 pkg.depotd tracebacks when given bad options
1237 pkg.depotd -p 80 -p 90 should return usage, but second option is taken
1887 depot status page output is not valid HTML
1888 memleaks test overwrites PYTHONPATH
webrev:
http://cr.opensolaris.org/~swalker/pkg-depot/
Notes:
* The tar streaming now has to write the file to a temporary file
first before streaming. This is an unfortunate side-effect of cherrypy
not providing a file object to write data directly back to the client.
Initially, I considered using a StringIO object, but that would have
bloated the server process quite a bit (memory usage).
* This is the most python I have ever written. Please excuse any
beginner's mistakes and be sure to watch out for them.
* This commit will cause cherrypy to be a *required* component for the
ips depot server.
* The tests take about 15-20 seconds longer to complete now.
* pylint was run and all reasonable warnings and errors were corrected
for files I changed.
* I have not yet done extensive performance testing, nor have I
checked for the threading issues that we previously had.
* You can cherrypy applications "behind apache" [1] -- and using a
reverse proxy is the recommended configuration to do so.
* Yes, cherrypy supports SSL, and if you run it behind Apache, let
Apache handle all the work [2].
* I'm expecting lots of feedback :-)
* Thanks to Danek for providing me the repository data that I needed
to do some of my own testing.
* Creating my own image, and then using the repo to do "pkg install
SUNWfirefox" was entertaining to say the least. It took six minutes
for the download portion, and one minute for install phase and
operation completion.
Cheers,
--
Shawn Walker
"To err is human -- and to blame it on a computer is even more so." -
Robert Orben
[1] http://tools.cherrypy.org/wiki/BehindApache
[2] http://tools.cherrypy.org/wiki/ApacheSSL
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
