I'm not okay with the fix to 941; one of the good things about using the hash is that it's deterministic, while mkstemp() isn't. I do like the removal of file_cleanup(), but I don't think this change is appropriate.
One of the things Bart's working on at the moment is changing how the files are downloaded, and I'm sure he has some ideas on what the download area needs to look like. I imagine we could get away without using the pathname, and using the hash alone, which would (I believe) fix your problem. Please talk to him about this. The fix to 1454 is fine, though you should get rid of the spaces at the end of the line while you're there. As best I can tell, the changes to setup.py are fine, though I wonder whether the print statement in build_py_func() is just for debugging? 1068 looks fine. I don't like having to explicitly list everything, and would rather have some way of decorating the methods so that lint would shut up, but this is fine for now. I might experiment with going back to using classes to get your inheritance, but once you've loaded the module with the class, extract all its methods into the module namespace. Since I'm out next week, you'll need to lobby someone else to shepherd your changes in, though I can do it once I get back if no one else has done so. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
