2008/5/20 Shawn Walker <[EMAIL PROTECTED]>: > 2008/5/11 Shawn Walker <[EMAIL PROTECTED]>: >> The following webrev includes proposed fixes for the following bugs: >> >> 1854 rework depot to use higher-level framework >> 1154 pkg.depotd tracebacks when given bad options >> 1237 pkg.depotd -p 80 -p 90 should return usage, but second option is >> taken >> 1887 depot status page output is not valid HTML >> 1888 memleaks test overwrites PYTHONPATH > > Newly added: > 1956 depotd performance hampered by unnecessary getpwuid/getgrgid calls
Try two (sorry for the first repost): Changes since last webrev: * Per Stephen, Johansen, I have changed the SUNWpython-cherrypy makefile to: -- Check to see if CherryPy-3.0.3.tar.gz exists in the package directory -- If it doesn't, it uses wget to retrieve it -- If it can't retrieve it, it will error and tell you what file you need to get and where to put it -- If it does exist, it decompresses it and installs it into proto * Per Johansen, I have added a -s parameter to depot.py so you can specify the number of threads for the cherrypy server thread pool. It also enforces a minimum of 1 and maximum of 100 for this parameter. * I have changed all the "hardcoded" values in depot.py for port, etc. into "constants" and placed them at the top of the file * I have fixed a regression in the command-line parsing to not have a traceback when an unknown option is specified * I have added an extensive comment explaining why the cherrypy.response.write change was needed in DepotResponse in depot.py * I have simplified repository.py's code for versions_0, filelist_0 and added lots of comments due to the "magic" involved in the latter * I added some special exception handling so that if the client is interrupted (broken pipe) the server won't throw a traceback or exception To make it easier to see the changes since the last webrev, I have created a special diff: http://cr.opensolaris.org/~swalker/pkg-depot-7/raw_files/pkg-depot-7.patch New webrev: http://cr.opensolaris.org/~swalker/pkg-depot-7/ Notes: To answer an earlier question, "cherrypy.request and cherrypy.response are thread-local objects, so that they are always accessible as globals (yet without the risk of concurrency issues)." Cheers, -- Shawn Walker "To err is human -- and to blame it on a computer is even more so." - Robert Orben _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
