On Mon, Jun 02, 2008 at 11:06:13PM -0500, Shawn Walker wrote: > > 142 doesn't fire? Is there any point in the code in this method from line > > Because of line 121, 142 should always fire if we get there. > > As a result, I have removed the op_method and "if" condition. The rest > should still do the right thing.
Okay. Looks much saner now. Though I think that we don't have to assume that the version isn't supported -- we can check explicitly. And give a "what the hell?" error if that's not the case. > > I'd probably go one step further and put the cherrypy build in its own > > target as well. Right now, it's going to rebuild cherrypy every single > > time you type make install. I'm not too annoyed by this yet, though, > > so maybe I'll be nice and fix it myself sometime later. > > I did that on purpose (due to how often I was doing make clobber and > trying to get things right during development), but I'm not opposed to > changing it. Though once you've gotten it right, you don't need as much of the "prevent me from doing silly things" in a makefile like this. At least IMO. > I've got it split up now so that it won't build the package for > CherryPy or install CherryPy unless the expected files are missing. Okay, that's probably fine. I can diddle with it if it bugs me enough. Looks like you need to remove the "perl-like" return from updatelog.py, too. I think it's probably fine otherwise. Danek _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
