On Wed, Jun 11, 2008 at 08:52:01PM -0700, [EMAIL PROTECTED] wrote:
> http://cr.opensolaris.org/~johansen/pkg-timeout2/
filelist.py:
- line 121: "receive" or "retrieve"?
- line 123: "This is a private method which performs the majority of the
work for add_content()." (Add ", which serves as a wrapper to handle
exceptions and retrieval from cache", if you really want.)
- line 168: I'd ditch this blank line.
image.py:
- line 455: I don't mean to make this silly, but perhaps this should be
_fetch_manifest_with_retries(), and what's now _download_manifest()
should be _fetch_manifest()? I don't think that the (English)
difference between "fetch" and "download" really tells us what the
difference between the two methods is.
- line 1222: "Clean"
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
