2008/6/19 Brock Pytlik <[EMAIL PROTECTED]>: > I'd like to suggest we update the pylintrc file we distribute to > actually mirror the standards we're using. The obvious change is to > switch the line length from 90 to 80, but I think we should make the > regex's for variables/function names/etc reflect the standards and stop > suppressing the warnings when something's wrong. We can decide if other > standards (max lines per module, max branches per function, etc...) are > things we care about or not (I tend to lean towards "no" in general, but > could be convinced otherwise). If we can't get pylint to enforce the 8 > spaces vs tab issue (something I'm unclear on at the moment) we can > write a small program to look for that problem as well.
If we didn't disable these (with disable-msg in our pylintrc), we would catch most of the indentation / tab / space problems: # W0311 Bad Indentation # W0311 Mixed (Space/Tab) Indentation > To make it less likely that more problems (on a large scale) will be > introduced, we can create "make lint" (or pylint, whatever) that will > automatically generate a lint report on the files you've touched (or > possibly all files, ideally this would be an option). The idea would be We already have that, in the form of "python setup.py lint". The one thing we don't have (as far as I know) is a lint based on only the files that changed -- that would be handy. > So, if this something we all think is worth doing, say so and we can > start moving towards consensus on the standards we should be encode into > pylintrc (and also think about standards we can't encode there and how > we might automate the testing of those as well). Code is read more often than it is written, so I think it's definitely worthwhile long-term. I'm willing to help out with this. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
