The code changes look fine. Unfortunately for me, I'm not sure I understand the difference between the _cp_config space and the stuff that was being configured by the decorator. Are you able to explain a little more about the root-cause of this problem?
Thanks, -j On Tue, Jun 24, 2008 at 06:29:22PM -0500, Shawn Walker wrote: > The following webrev includes proposed fixes for the following bugs: > > 2293 filelist is returning incorrect Content-Type header > > webrev: > http://cr.opensolaris.org/~swalker/pkg-2293/ > > Change summary: > I changed the filelist_0 method to use the _cp_config namespace > instead of the @tools.response.headers mechanism. > > This is because @tools hooks into the "on_start_resource" portion of a > request/response which is too late in the process to set headers when > response.stream == True. > > Arguably, this may be a cherrypy bug, but since the documentation > doesn't explicitly say, it's difficult to ascertain. I will be filing > a bug with the cherrypy folks to see if that is the case. > > I verified that this worked as expected by running a depot server with > the new changes and checking the output of wget thusly: > > wget -S http://localhost:10000/filelist/0/ -O /dev/null > > Eventually, I'd like to have tests for the output of the depot server > to verify that headers, etc. are set as expected. However, that's a > separate issue and is filed as bug 2300. > > Cheers, > Cheers, > -- > Shawn Walker > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
