This looks fine to me. -j
On Wed, Jun 25, 2008 at 10:31:48PM -0500, Shawn Walker wrote: > The following webrev includes proposed fixes for the following bugs: > > 2331 depot command-line parsing errors cause traceback > 2332 depot command-line parsing could be more helpful > > webrev: > http://cr.opensolaris.org/~swalker/pkg-parse/ > > Change summary: > * I fixed a boneheaded mistake I made when putting back 1845 in the > command-line parsing OptionError exception class. I know it worked at > one point, but I apparently made a change and didn't re-test properly. > That change is in depot.py. > > * I changed depot.py to simply print the error that getopt provides > whenever it throws an exception directly since it knows what all the > cases are and provides a far more helpful message. > > * I fixed a bug in port_available in misc.py when specifying illegal > port values which was causing a traceback instead of showing a helpful > error message. > > Cheers, > -- > Shawn Walker > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
