Danek Duvall wrote:
On Thu, Jun 26, 2008 at 05:29:11PM -0500, Tom Mueller (pkg-discuss) wrote:
http://cr.opensolaris.org/~tmueller/cr-2209,2222,2343/
license.py
- line 77: you're not actually making sure the directory is writable,
just that it exists. I'd change the comment to match the code.
- line 80: this could be an "elif", as path couldn't exist if the
directory hadn't previously.
both fixed. Code now is:
# make sure the directory exists and the file is writable
if not os.path.exists(os.path.dirname(path)):
self.makedirs(os.path.dirname(path), mode=755)
elif os.path.exists(path):
os.chmod(path, 0644)
Shawn Walker wrote:
http://cr.opensolaris.org/~tmueller/cr-2209,2222,2343/src/modules/client/image.py.wdiff.html
==========
1272 + os.makedirs(parent)
Should you have a ", mode=755" on the end of this?
I'll leave this one as is per Danek's response to a similar comment on
another code review about using the default.
Thank you for the review.
Tom
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
