Tom,

> The design spec for this feature, as discussed previously on 
> pkg-discuss, is contained in the issue:
> 
> http://defect.opensolaris.org/bz/show_bug.cgi?id=856

I really don't think this design is complete.  It looks to me like
somebody said, "We need an image title." Then the entire property
interface was designed around that.

It seems like we ought to be able to unify the property space to
encapsulate all of the different image configuration options as
properties.  Aren't authority, filter, image-policy, and mirroring
options all properties that are specific to an image?

This design just adds another set/unset/<name> triplet which is only
going to get worse as we add more features to the configuration.  If you
put this back, and I follow up with mirroring, we'll have:

set-authority
unset-authority
authority
set-mirror
unset-mirror
set-property
unset-property
property

This isn't a very usable command-line interface.  As we add options to
the config, it'll only get worse.

> webrev: http://cr.opensolaris.org/~tmueller/cr-856/

imageconfig.py:

   -line 111: Use ConfigParser.has_section() here instead

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to