On Fri 11 Jul 2008 at 01:44PM, Brock Pytlik wrote:
> A pretty simple and straightforward change I think.
> It splits the execute function in imageplan into two steps and moves the
> be/snapshot creation to be after the packages have been downloaded to
> disk, but before any actual actions have been performed.
>
> Here's the webrev:
> http://cr.opensolaris.org/~bpytlik/ips-1249/
Can you do me a favor and chmod src/client.py to be 644? I don't know
who is doing putbacks which are causing files to be 755, but it's
annoying :)
---
483: shouldn't this say: "during install"?
599: shouldn't this say: "during uninstall"?
---
600: please add one line of whitespace between 600 and 601
---
I assume you've tested this with e.g. ctrl-C during a download?
---
In your pair of exception handlers, you go to some effort to cope with
"None", but it seems like the result will be:
An unexpected error happened during image-update:
Perhaps at 383, 482 and 597, set tmp = "Unknown Error"
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
