Danek, setup.py, line 345: Doesn't there need to be a return value here?
Otherwise looks fine. Thanks. Tom Danek Duvall wrote: > I've fixed a couple more things that were bugging me about make install, > and would like to get them out of my queue. > > First, there's no way not to create the svr4 packages. I mostly don't care > about that, and any errors in the build get wiped out by pkgmk's massive > output. So I've introduced a new make target, "install-nopkg". If people > prefer that behavior, I can make it the default, and have a separate target > to go make the packages. > > The second thing is that the version substitution for modules/__init__.py > happens each and every time, even though it doesn't actually change all > that often. So I've added some code to parse the installed module for its > version and only re-install it if the workspace id has changed. Note that > the normal timestamp check won't work because the source file never > actually changes. > > The webrev is at > > http://cr.opensolaris.org/~dduvall/pkg-setup/ > > I'll file a bug when I'm ready to put back. > > Thanks, > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
