Danek Duvall wrote:
> [snip]
>
> I think we need a text file in the doc directory explaining how all this
> works.
>
> [snip]
A new webrev is here which adds the doc file Danek requested, fixes some 
locking issues in server/query_engine.py, cleans up a few typos, and 
adds a new test and some docstrings to t_search.py. Two tests in 
t_search.py were combined into a single test. The test in 
server/query_engine.py on line 54 was changed to explicitly check 
against None being returned and a comment was added just above it.

I'd especially appreciate comments on the changes in 
server/query_engine.py and the changes in manifest.py which appeared in 
v1. (Sorry, I don't have a diff for v1 -> v2, but I'll make sure I can 
generate that from now on.)

http://cr.opensolaris.org/~bpytlik/ips-search-v2/


Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to