On Mon, Aug 04, 2008 at 07:28:33PM -0700, Dan Price wrote: > http://cr.opensolaris.org/~dp/pkg-verify-2784/
Perhaps consolidate the first two ifs into a single statement? Why not get rid of didelfcheck, set elfhash = None at the top, and check to test for None outside the if? Line 164 in user.py probably shouldn't say OSError, since it could potentially be an IOError. Either say "Error" or "EnvironmentError". Or e.__class__.__name__. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
